Changeset fbf005 for src/poolworker.cpp

Timestamp:

Mar 9, 2017, 9:43:23 AM (8 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_ChronosMutex, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, PartialCharges_OrthogonalSummation, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, RotateToPrincipalAxisSystem_UndoRedo, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, Ubuntu_1604_changes, stable

Children:

7672284

Parents:

ba1152

git-author:

Frederik Heber <heber@…> (03/08/17 08:11:59)

git-committer:

Frederik Heber <heber@…> (03/09/17 09:43:23)

Message:

HUGE: Extracted libmolecuilder_mpqc that is now linked to poolworker.

• This stops the problems with MemDebug and mpqc when linking against libLinearAlgebra in debug mode: static global variables in libLinAlg are allocated using MemDebug (prefixed with a checksum) but are deallocated using normal libc's free() on exit. This causes an invalid free() as the ptr given to free points inside the block and not at its start. The problem comes from mpqc's use of own new and delete implementation. I'm guessing its reference counting is the culprit. Hence, we need to separate these two compilations from another in different units/libraries. Therefore, we have split off libmolecuilder_mpqc, .._mpqc_extract and additionally place the MPQCJob::Work() implementation inside libMolecuilderJobs_Work.
• libmolecuilder_mpqc contains all MPQC's code in mpqc.cc (and linked libraries) that is not the main() function.
• libmolecuilder_mpqc_extract contains functions that extract results such as energies, forces, charge grids from the obtained mpqc solution. These were added by myself to the mpqc code before.
• molecuilder_mpqc is then linked against a NoOp .._extract library version. Thereby, it does not use any of the Molecuilder or related libraries and does not come in contact with MemDebug.
• molecuilder_poolworker however is linked with the full .._extract library and hence performs these extractions.
• poolworker now executes MPQCJob, MPQCCommandJob, and VMGJob and therefore needs to enforce binding to all of them.
• TESTS: renamed molecuilder_mpqc.in to molecuilder_poolworker.in.

File:

• src/poolworker.cpp (modified) (1 diff)

src/poolworker.cpp

@@ -36 +36 @@
 #include "CodePatterns/MemDebug.hpp"
 
+#include <string>
+
+#include <boost/bind.hpp>
+#include <boost/tokenizer.hpp>
+
 #include "JobMarket/poolworker_main.hpp"
+
+#include "mpqc.h"
 
 // force binding to libMolecuilderJobs
 // note we bind here to sort-of mock objects which are bases on SystemCommandJob
 #include "Jobs/MPQCCommandJob_binding.hpp"
-// poolworker has nothing to do with VMG jobs
+#include "Jobs/MPQCJob_binding.hpp"
+#include "Jobs/VMGJob_binding.hpp"
 
 int main(int argc, char* argv[])
 {
-  return poolworker_main(argc,argv);
+  mpqc::InitValues initvalues;
+
+  mpqc::init(initvalues, argc, argv);
+
+  const int exitflag = poolworker_main(argc, argv);
+
+  mpqc::cleanup(initvalues);
+
+  return exitflag;
 }