Changeset ca1535 for src/UIElements/Views/Qt4/MoleculeList/QtMoleculeItem.cpp

Timestamp:

Feb 12, 2016, 11:15:39 PM (9 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

deb5ee

Parents:

1b6415a

git-author:

Frederik Heber <heber@…> (10/29/15 22:21:30)

git-committer:

Frederik Heber <heber@…> (02/12/16 23:15:39)

Message:

All QtMoleculeItem now heed QtObservedMolecule and QtMoleculeList takes InstanceBoard.

• QtMoleculeItems no longer use Observer/Observable but get updates via signal/slot from QtObservedMolecule.
• QtMoleculeList listens to its molecule signals.

File:

• src/UIElements/Views/Qt4/MoleculeList/QtMoleculeItem.cpp (modified) (2 diffs)

src/UIElements/Views/Qt4/MoleculeList/QtMoleculeItem.cpp

@@ -35 +35 @@
 #include "QtMoleculeItem.hpp"
 
-#include <QModelIndex>
-
 #include "UIElements/Views/Qt4/MoleculeList/QtMoleculeList.hpp"
 
 #include "CodePatterns/MemDebug.hpp"
 
-#include "CodePatterns/Assert.hpp"
-#include "CodePatterns/toString.hpp"
-
-#include "CodePatterns/Observer/Notification.hpp"
-
-#include <algorithm>
-
-#include <boost/thread/locks.hpp>
-
-#include "Descriptors/MoleculeIdDescriptor.hpp"
-#include "molecule.hpp"
-#include "World.hpp"
-
 QtMoleculeItem::QtMoleculeItem(
-     const moleculeId_t _molid,
-     const channellist_t &_channellist,
+    QtObservedMolecule::ptr &_ObservedMolecule,
      const enum MoveTypes _movetype,
-     const emitDirtyState_t _emitDirtyState,
-     const emitSubjectKilledState_t _emitSubjectKilledState) :
-  Observer("QtMoleculeItem"),
-  molid(_molid),
+     const emitDirtyState_t _emitDirtyState) :
+  ObservedMolecule(_ObservedMolecule),
   movetype(_movetype),
-  channellist(_channellist),
-  owner(NULL),
   dirty(true),
-  emitDirtyState(_emitDirtyState),
-  emitSubjectKilledState(_emitSubjectKilledState)
+  emitDirtyState(_emitDirtyState)
 {
-  // BUG: We cannot sign on here as then and again we catch "pure virtual function called"
-  // this makes no sense as both the Observer part (which also has a recievedNotification())
-  // nor QtMoleculeItem's vtable have been fully created.
-//  signOnToMolecule();
   setFlags(flags() | Qt::ItemIsSelectable);
-}
-
-void QtMoleculeItem::signOnToMolecule()
-{
-  // count the number of threads entering the function
-  std::cout << "QtMoleculeItem::signOnToMolecule() called for " << this << std::endl;
-  const molecule * const mol = const_cast<const World &>(World::getInstance()).
-      getMolecule(MoleculeById(molid));
-  if (mol != NULL) {
-    owner_mutex.lock();
-    if (owner == NULL) {
-      owner_mutex.unlock();
-      const Observable *owner_copy = static_cast<const Observable *>(mol);
-      for (channellist_t::const_iterator channeliter = channellist.begin();
-          channeliter != channellist.end(); ++channeliter)
-        owner_copy->signOn(this, *channeliter);
-      owner_mutex.lock();
-      owner = owner_copy;
-      owner_mutex.unlock();
-      std::cout << "QtMoleculeItem " << this << " has signed on to " << owner << std::endl;
-    } else
-      owner_mutex.unlock();
-  }
-}
-
-void QtMoleculeItem::signOffFromMolecule()
-{
-  // prevent via owner that another thread enters the function again
-  // (re-entrancy)
-  const Observable *owner_copy;
-  {
-    boost::recursive_mutex::scoped_lock lock(owner_mutex);
-    if (owner != NULL) {
-      owner_copy = owner;
-      owner = NULL;
-    }
-  }
-  std::cout << "QtMoleculeItem::signOffFromMolecule() called for " << this << std::endl;
-  if (owner_copy != NULL) {
-    for (channellist_t::const_iterator channeliter = channellist.begin();
-        channeliter != channellist.end(); ++channeliter)
-      owner_copy->signOff(this, *channeliter);
-    std::cout << "QtMoleculeItem " << this << " has signed off from " << owner_copy << std::endl;
-    owner_copy = NULL;
-  }
 }
 
 QtMoleculeItem::~QtMoleculeItem()
 {
-  // BUG: We cannot sign off here as then and again we catch "pure virtual function called"
-  // this makes no sense as neither the Observer part (which also has a recievedNotification())
-  // nor QtMoleculeItem's vtable have yet been destroyed.
-  signOffFromMolecule();
 }
 
@@ -136 +62 @@
   }
 }
-
-void QtMoleculeItem::update(Observable *publisher)
-{}
-
-void QtMoleculeItem::recieveNotification(Observable *publisher, Notification_ptr notification)
-{
-  if (dynamic_cast<molecule *>(publisher) != NULL) {
-    if (notification->getChannelNo() == molecule::AboutToBeRemoved) {
-      signOffFromMolecule();
-      // prevent any remaining updates from accessing the molecule
-      //molid = -1;
-      dirty = false;
-    } else {
-      channellist_t::const_iterator iter =
-          std::find(channellist.begin(), channellist.end(), notification->getChannelNo());
-      if (iter != channellist.end()) {
-        dirty = true;
-        emitDirtyState(getMoleculeId(), getType(), movetype);
-      } else {
-        ASSERT(0,
-            "QtMoleculeItem::recieveNotification() - received notification to channel "
-            +toString(notification->getChannelNo())+" we are not subscribed to.");
-      }
-    }
-  }
-}
-
-void QtMoleculeItem::subjectKilled(Observable *publisher)
-{
-//  signOffFromMolecule();
-  dirty = false;
-  emitSubjectKilledState(getMoleculeId());
-}
-
-const molecule * const QtMoleculeItem::getMolecule() const
-{
-  const molecule * const mol = const_cast<const World &>(World::getInstance()).getMolecule(MoleculeById(molid));
-//  ASSERT (mol != NULL,
-//      "QtMoleculeItem::getMolecule() - mol with "+toString(molid)+" is gone.");
-  return mol;
-}