Changeset bf87c2 for src/UIElements/CommandLineUI/Query/KeyValuePairCommandLineQuery.cpp

Timestamp:

Jul 17, 2017, 12:28:51 PM (8 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Action_Thermostats, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults

Children:

3bd4a66

Parents:

9346af

git-author:

Frederik Heber <frederik.heber@…> (07/06/17 22:18:13)

git-committer:

Frederik Heber <frederik.heber@…> (07/17/17 12:28:51)

Message:

Query::handle() no longer returns bool but has internal result flag.

• we use this flag conditionally in setResult(), i.e. if the handle() has failed, then we should not set its result which might overwrite a present default value in the parameter.
• this fixes the problem with StepWorldTime which has a default value of 1 but which was overwritten with 0 because of the non-conditionally calling of setResult().
• this required change of "output-types" default parameter to an empty vector. So far, we were just lucky that this actually worked.
• also StoreSaturatedFragmentAction needed the same change as default values have to be consistent over the specific token.

File:

• src/UIElements/CommandLineUI/Query/KeyValuePairCommandLineQuery.cpp (modified) (2 diffs)

src/UIElements/CommandLineUI/Query/KeyValuePairCommandLineQuery.cpp

@@ -49 +49 @@
 CommandLineDialog::KeyValuePairCommandLineQuery::~KeyValuePairCommandLineQuery() {}
 
-bool CommandLineDialog::KeyValuePairCommandLineQuery::handle() {
+void CommandLineDialog::KeyValuePairCommandLineQuery::handle() {
   if (CommandLineParser::getInstance().vm.count(getTitle())) {
     try {
@@ -55 +55 @@
     } catch(boost::bad_any_cast &e) {
       temp = KeyValuePair(std::string(""));
-      return false;
+      return;
     }
-    return true;
+    handleSuccess = true; return;
   }
-  return false;
 }