Changeset b540f3 for src/Actions/MapOfActions.cpp

Timestamp:

Jul 6, 2010, 3:50:04 PM (15 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

192f6e

Parents:

62c3dde

Message:

changed validate() for VectorValue, parsing not 10. 10. 10. but "10., 10., 10." to allow for negative values.

• i.e. we now parse a single string and tokenize it ourselves.
• TESTFIX: alle test cases asking the user for vectors had to be changed accordingly.

File:

• src/Actions/MapOfActions.cpp (modified) (3 diffs)

src/Actions/MapOfActions.cpp

@@ -71 +71 @@
 {
   VectorValue VV;
-  if (values.size() != 3) {
-    cerr <<  "Specified vector does not have three components but " << values.size() << endl;
+  std::vector<std::string> components;
+
+  // split comma-separated values
+  if (values.size() != 1) {
+    cerr <<  "Not one vector but " << components.size() << " given " << endl;
+    throw boost::program_options::validation_error("Unequal to one vector given");
+  }
+  std::string argument(values.at(0));
+  std::string::iterator Aiter = argument.begin();
+  std::string::iterator Biter = argument.begin();
+  for (; Aiter != argument.end(); ++Aiter) {
+    if (*Aiter == ',') {
+      components.push_back(string(Biter,Aiter));
+      do {
+        Aiter++;
+      } while (*Aiter == ' ' || *Aiter == '\t');
+      Biter = Aiter;
+    }
+  }
+  components.push_back(string(Biter,argument.end()));
+
+  if (components.size() != 3) {
+    cerr <<  "Specified vector does not have three components but " << components.size() << endl;
     throw boost::program_options::validation_error("Specified vector does not have three components");
   }
-  VV.x = boost::lexical_cast<double>(values.at(0));
-  VV.y = boost::lexical_cast<double>(values.at(1));
-  VV.z = boost::lexical_cast<double>(values.at(2));
+  VV.x = boost::lexical_cast<double>(components.at(0));
+  VV.y = boost::lexical_cast<double>(components.at(1));
+  VV.z = boost::lexical_cast<double>(components.at(2));
   v = boost::any(VectorValue(VV));
 }
@@ -84 +105 @@
 {
   BoxValue BV;
-  if (values.size() != 6) {
-    cerr <<  "Specified vector does not have three components but " << values.size() << endl;
+  std::vector<std::string> components;
+
+  // split comma-separated values
+  if (values.size() != 1) {
+    cerr <<  "Not one vector but " << components.size() << " given " << endl;
+    throw boost::program_options::validation_error("Unequal to one vector given");
+  }
+  std::string argument(values.at(0));
+  std::string::iterator Aiter = argument.begin();
+  std::string::iterator Biter = argument.begin();
+  for (; Aiter != argument.end(); ++Aiter) {
+    if (*Aiter == ',') {
+      components.push_back(string(Biter,Aiter));
+      do {
+        Aiter++;
+      } while (*Aiter == ' ' || *Aiter == '\t');
+      Biter = Aiter;
+    }
+  }
+  components.push_back(string(Biter,argument.end()));
+
+  if (components.size() != 6) {
+    cerr <<  "Specified vector does not have three components but " << components.size() << endl;
     throw boost::program_options::validation_error("Specified symmetric box matrix does not have six components");
   }
-  BV.xx = boost::lexical_cast<double>(values.at(0));
-  BV.xy = boost::lexical_cast<double>(values.at(1));
-  BV.xz = boost::lexical_cast<double>(values.at(2));
-  BV.yy = boost::lexical_cast<double>(values.at(3));
-  BV.yz = boost::lexical_cast<double>(values.at(4));
-  BV.zz = boost::lexical_cast<double>(values.at(5));
+  BV.xx = boost::lexical_cast<double>(components.at(0));
+  BV.xy = boost::lexical_cast<double>(components.at(1));
+  BV.xz = boost::lexical_cast<double>(components.at(2));
+  BV.yy = boost::lexical_cast<double>(components.at(3));
+  BV.yz = boost::lexical_cast<double>(components.at(4));
+  BV.zz = boost::lexical_cast<double>(components.at(5));
   v = boost::any(BoxValue(BV));
 }
@@ -587 +629 @@
             ListRunner->second->add_options()
               (getKeyAndShortForm(*OptionRunner).c_str(),
-                  po::value<VectorValue>()->multitoken(),
+                  po::value<VectorValue>(),
                   getDescription(*OptionRunner).c_str())
               ;