Changeset 9eb71b3 for src/Actions/Action.cpp

Timestamp:

May 5, 2017, 2:08:59 PM (8 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph_documentation, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, Fix_ChronosMutex, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, RotateToPrincipalAxisSystem_UndoRedo, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, Ubuntu_1604_changes

Children:

ac9dc8

Parents:

aa91de0

git-author:

Frederik Heber <frederik.heber@…> (05/05/17 12:22:20)

git-committer:

Frederik Heber <frederik.heber@…> (05/05/17 14:08:59)

Message:

Commented out MemDebug include and Memory::ignore.

• MemDebug clashes with various allocation operators that use a specific placement in memory. It is so far not possible to wrap new/delete fully. Hence, we stop this effort which so far has forced us to put ever more includes (with clashes) into MemDebug and thereby bloat compilation time.
• MemDebug does not add that much usefulness which is not also provided by valgrind.

File:

• src/Actions/Action.cpp (modified) (3 diffs)

src/Actions/Action.cpp

@@ -33 +33 @@
 #endif
 
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 
 #include <iostream>
@@ -45 +45 @@
 #include "UIElements/Dialog.hpp"
 #include "CodePatterns/Assert.hpp"
-#include "CodePatterns/MemDebug.hpp"
+//#include "CodePatterns/MemDebug.hpp"
 #include "UIElements/UIFactory.hpp"
 
@@ -54 +54 @@
 
 ActionState::ptr getEmptyState() {
-  return ActionState::ptr(Memory::ignore(new ActionState()));
+  return ActionState::ptr( 
+        /* Memory::ignore( */
+        new ActionState())
+        /* ) */
+        ;
 }