Changeset 4e4940 for molecuilder/src/molecules.cpp

Timestamp:

Aug 3, 2009, 8:10:09 AM (16 years ago)

Author:

Frederik Heber <heber@…>

Children:

0e2190, 834ff3

Parents:

3dc682

Message:

We are one step further in fixing the convex hull: There are two functions of Saskia Metzler missing, but then we may proceed with testing whether the simple correction scheme of the convex envelope works, but one thing: Right now we cannot associate a Tesselation to its molecule as the snake bites it's one tail. Hence, the next commit will consist of fixing this bad-OOP issue.

• Makefile.am: Just some alphabetical resorting.
• atom::atom() new copy constructor
• builder.cpp: some output for cluster volume, molecule::AddCopyAtom() uses new copy constructor
• FillBoxWithMolecule() - new function to fill the remainder of the simulation box with some given filler molecules. Makes explicit use of the tesselated surfaces
• find_convex_border() - InsertStraddlingPoints() and CorrectConcaveBaselines() is called to correct for atoms outside the envelope and caused-by concave points
• Tesselation::InsertStraddlingPoints() enlarges the envelope for all atoms found outside, Tesselation::CorrectConcaveBaselines() corrects all found baselines if the adjacent triangles are concave by flipping.
• boundary.cpp: Lots of helper routines for stuff further below:
  • BoundaryLineSet::IsConnectedTo() checks whether lines have common endpoint
  • BoundaryLineSet::CheckConvexityCriterion() checks whether adjacent triangles are convex or concave
  • BoundaryLineSet::ContainsBoundaryPoint() checks whether line contains a given boundary point
  • BoundaryTriangleSet::ContainsBoundaryLine() and BoundaryTriangleSet::ContainsBoundaryPoint() check whether triangle contains boundary line or point
  • BoundaryTriangleSet::GetIntersectionInsideTriangle() calculates intersection point between line and triangle,
• The following routines are needed to check whether point is in- or outside:
  • Vector::GetIntersectionWithPlane() calculates intersection point of a plane and a line.
  • Vector::GetIntersectionOfTwoLinesOnPlane() intersection of two lines on the same plane.
• FIX: Tesselation::AddPoint() - newly created BoundaryPoint is removed if already present.

Problem: We want to associate a Tesselation class with each molecule class. However, so far we have to know about atoms and bond and molecules inside the Tesselation. We have to remove this dependency and create some intermediate class which enables/encapsulates the access to Vectors, e.g. hidden inside the atom class. This is also good OOP! The Tesselation also only needs a set of Vectors, not more!

File:

• molecuilder/src/molecules.cpp (modified) (1 diff)

molecuilder/src/molecules.cpp

@@ -120 +120 @@
 {
   if (pointer != NULL) {
-    atom *walker = new atom();
-    walker->type = pointer->type;  // copy element of atom
-    walker->x.CopyVector(&pointer->x); // copy coordination
-    walker->v.CopyVector(&pointer->v); // copy velocity
-    walker->FixedIon = pointer->FixedIon;
-    walker->sort = &walker->nr;
+    atom *walker = new atom(pointer);
+    walker->Name = (char *) Malloc(sizeof(char)*strlen(pointer->Name)+1, "atom::atom: *Name");
+    strcpy (walker->Name, pointer->Name);
     walker->nr = last_atom++;  // increase number within molecule
-    walker->father = pointer; //->GetTrueFather();
-    walker->Name = (char *) Malloc(sizeof(char)*strlen(pointer->Name)+1, "molecule::AddCopyAtom: *Name");
-    strcpy (walker->Name, pointer->Name);
     add(walker, end);
     if ((pointer->type != NULL) && (pointer->type->Z != 1))