Changeset 476781 for src/UIElements/Views/Qt4/QtHomologyList.cpp

Timestamp:

Aug 30, 2025, 2:41:40 PM (2 months ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

Candidate_v1.7.0, stable

Children:

5a255af

Parents:

d56114

git-author:

Frederik Heber <frederik.heber@…> (08/15/25 19:06:31)

git-committer:

Frederik Heber <frederik.heber@…> (08/30/25 14:41:40)

Message:

FIX: fixes several issues in QtHomologyList related to plotting.

• the curve was added twice: once through the signal from QSeisCurveRegistry and the second time through a direct call. The latter is now removed.
• We now plot all potentials (not just harmonic bond) by using default xvalues for constant. The harmonic bond was plotted because the bond length appeared twice in the exemplary water molecule while the harmonic angle appears only once. This is also fixed.

File:

• src/UIElements/Views/Qt4/QtHomologyList.cpp (modified) (4 diffs)

src/UIElements/Views/Qt4/QtHomologyList.cpp

@@ -220 +220 @@
       std::vector<double> xvalues;
       std::vector<double> yvalues;
-      for (TrainingData::OutputVector_t::const_iterator outputiter = outputs.begin();
-          outputiter != outputs.end(); ++outputiter)
-        yvalues.push_back((*outputiter)[0]);
 
       // go through each potential
@@ -234 +231 @@
         // then we need to sample the potential
         HomologyGraph dummy;
+
         xvalues.clear();
+        yvalues.clear();
+        for (TrainingData::OutputVector_t::const_iterator outputiter = outputs.begin();
+            outputiter != outputs.end(); ++outputiter)
+          yvalues.push_back((*outputiter)[0]);
         for (TrainingData::InputVector_t::const_iterator inputiter = inputs.begin();
             inputiter != inputs.end(); ++inputiter) {
@@ -244 +246 @@
             average += (*coordinator)(args);
           }
+          const size_t index =  xvalues.size();
           if (specificargs.size() > 1) {
-            const size_t index =  xvalues.size();
             xvalues.push_back(average/(double)specificargs.size());
-            yvalues[index] *= 1./(double)specificargs.size();
+          } else if (specificargs.size() == 1) {
+            xvalues.push_back(average);
+          } else {
+            xvalues.push_back(index/0.1);
           }
         }
@@ -284 +289 @@
           else
             delete curve;
-          // couple to QSeisPlotPage
-          widget->addCurve(potentialname);
         }
       }