Changeset 2344a3 for src/Fragmentation/Automation/FragmentScheduler.cpp

Timestamp:

Jul 2, 2012, 7:54:11 AM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

1cfd17

Parents:

fb255d

git-author:

Frederik Heber <heber@…> (03/04/12 16:24:25)

git-committer:

Frederik Heber <heber@…> (07/02/12 07:54:11)

Message:

FragmentScheduler is now an Observer of JobsQueue and pool.

• ControllerListener gets a bound function shutdown() to pass on shutdown request from controller on to FragmentScheduler itself to shutdown both sockets and the io_service.
• FragmentScheduler is notified of JobAdded and WorkerIdle to send out jobs to workers.
• Now, FragmentScheduler always initiates WorkerListener's socket.
• removed temporary construct in WorkerListener_t::handle_ReceivedResults which launched the next job.
• TESTFIX: Regression test Fragmenation/Automation completerun now sends three jobs (this would have lead to crash with temporary construct above).

File:

• src/Fragmentation/Automation/FragmentScheduler.cpp (modified) (11 diffs)

src/Fragmentation/Automation/FragmentScheduler.cpp

@@ -34 +34 @@
 #include "CodePatterns/Info.hpp"
 #include "CodePatterns/Log.hpp"
+#include "CodePatterns/Observer/Notification.hpp"
+#include "ControllerChoices.hpp"
 #include "Controller/Commands/EnrollInPoolOperation.hpp"
 #include "Jobs/MPQCCommandJob.hpp"
@@ -41 +43 @@
 #include "FragmentScheduler.hpp"
 
-FragmentJob::ptr FragmentScheduler::WorkerListener_t::NoJob(new SystemCommandJob(std::string("/bin/true"), std::string("dosomething"), JobId::NoJob));
+FragmentJob::ptr FragmentScheduler::NoJob(new SystemCommandJob(std::string(""), std::string(""), JobId::NoJob));
 
 /** Helper function to enforce binding of FragmentWorker to possible derived
@@ -59 +61 @@
  * \param controllerport port to listen for controller connections.
  */
-FragmentScheduler::FragmentScheduler(boost::asio::io_service& io_service, unsigned short workerport, unsigned short controllerport) :
-    WorkerListener(io_service, workerport, JobsQueue, pool,
+FragmentScheduler::FragmentScheduler(boost::asio::io_service& _io_service, unsigned short workerport, unsigned short controllerport) :
+    Observer("FragmentScheduler"),
+    io_service(_io_service),
+    WorkerListener(_io_service, workerport, JobsQueue, pool,
         boost::bind(&FragmentScheduler::sendJobToWorker, boost::ref(*this), _1, _2)),
-    ControllerListener(io_service, controllerport, JobsQueue,
-        boost::bind(&Listener::initiateSocket, boost::ref(WorkerListener))),
-    connection(io_service),
+    ControllerListener(_io_service, controllerport, JobsQueue,
+        boost::bind(&FragmentScheduler::shutdown, boost::ref(*this))),
+    connection(_io_service),
     sendJobOp(connection)
 {
   Info info(__FUNCTION__);
+
+  // sign on to idle workers and present jobs
+  pool.signOn(this, WorkerPool::WorkerIdle);
+  JobsQueue.signOn(this, FragmentQueue::JobAdded);
 
   // listen for controller
   ControllerListener.initiateSocket();
 
-  // only initiate socket if jobs are already present
-  if (JobsQueue.isJobPresent()) {
-    WorkerListener.initiateSocket();
-  }
+  // listen for workers
+  WorkerListener.initiateSocket();
+}
+
+FragmentScheduler::~FragmentScheduler()
+{
+  // sign off
+  pool.signOff(this, WorkerPool::WorkerIdle);
+  JobsQueue.signOff(this, FragmentQueue::JobAdded);
 }
 
@@ -208 +221 @@
     // restore NoOperation choice such that choice is not read twice
     choice = NoWorkerOperation;
+
+    initiateSocket();
   }
   else
@@ -217 +232 @@
     ELOG(0, e.message());
   }
-
-  if (JobsQueue.isJobPresent()) {
-    // Start an accept operation for a new Connection only when there
-    // are still jobs present
-    initiateSocket();
-  }
 }
 
@@ -234 +243 @@
 {
   Info info(__FUNCTION__);
-  if (!e)
-  {
-    if (JobsQueue.isJobPresent()) {
-      FragmentJob::ptr job = JobsQueue.popJob();
-      callback_sendJobToWorker(pool.getNextIdleWorker(), job);
-    }
-  }
-  else
+  if (e)
   {
     // An error occurred. Log it and return. Since we are not starting a new
@@ -276 +278 @@
   result.reset();
   LOG(1, "INFO: JobsQueue has " << JobsQueue.getDoneJobs() << " results.");
-
-  // send out new job if present
-  if (JobsQueue.isJobPresent()) {
-    FragmentJob::ptr job = JobsQueue.popJob();
-    callback_sendJobToWorker(pool.getNextIdleWorker(), job);
-  }
 }
 
@@ -412 +408 @@
       // Start an accept operation for a new Connection.
       initiateSocket();
+    } else {
+      // we shutdown? Hence, also shutdown controller
+      shutdownAllSockets();
     }
   }
@@ -436 +435 @@
 {
   Info info(__FUNCTION__);
-  bool need_initiateSocket = !JobsQueue.isJobPresent();
-
   // jobs are received, hence place in JobsQueue
   if (!jobs.empty()) {
@@ -443 +440 @@
     JobsQueue.pushJobs(jobs);
   }
-
   jobs.clear();
-
-  // initiate socket if we had no jobs before
-  if (need_initiateSocket)
-    initiateWorkerSocket();
 }
 
@@ -504 +496 @@
 }
 
-///** Helper function to shutdown a single worker.
-// *
-// * We send NoJob to indicate shutdown
-// *
-// * @param address of worker to shutdown
-// */
-//void FragmentScheduler::shutdownWorker(const WorkerAddress &address)
-//{
-//  sendJobToWorker(address, NoJob);
-//}
-//
-///** Sends shutdown to all current workers in the pool.
-// *
-// */
-//void FragmentScheduler::removeAllWorkers()
-//{
-//  // give all workers shutdown signal
-//  while (pool.presentIdleWorkers()) {
-//    const WorkerAddress address = pool.getNextIdleWorker();
-//    shutdownWorker(address);
-//  }
-//}
+/** Helper function to shutdown a single worker.
+ *
+ * We send NoJob to indicate shutdown
+ *
+ * @param address of worker to shutdown
+ */
+void FragmentScheduler::shutdownWorker(const WorkerAddress &address)
+{
+  LOG(3, "DEBUG: Shutting down worker " << address << "...");
+  sendJobToWorker(address, NoJob);
+}
+
+/** Sends shutdown to all current workers in the pool.
+ *
+ */
+void FragmentScheduler::removeAllWorkers()
+{
+  LOG(2, "INFO: Shutting down workers ...");
+
+  // give all workers shutdown signal
+  while (pool.presentIdleWorkers()) {
+    const WorkerAddress address = pool.getNextIdleWorker();
+    shutdownWorker(address);
+  }
+}
+
+/** Helper function to shutdown the server properly.
+ *
+ * \todo one should idle here until all workers have returned from
+ * calculating stuff (or workers need to still listen while the are
+ * calculating which is probably better).
+ *
+ */
+void FragmentScheduler::shutdown()
+{
+  LOG(1, "INFO: Shutting all down ...");
+
+  /// Remove all workers
+  removeAllWorkers();
+
+  /// close the worker listener's socket
+  WorkerListener.closeSocket();
+
+  /// close the controller listener's socket
+  ControllerListener.closeSocket();
+
+  /// finally, stop the io_service
+  io_service.stop();
+}
+
+/** Internal helper to send the next available job to the next idle worker.
+ *
+ */
+void FragmentScheduler::sendAvailableJobToNextIdleWorker()
+{
+  const WorkerAddress address = pool.getNextIdleWorker();
+  FragmentJob::ptr job = JobsQueue.popJob();
+  sendJobToWorker(address, job);
+}
+
+void FragmentScheduler::update(Observable *publisher)
+{
+  ASSERT(0, "FragmentScheduler::update() - we are not signed on for global updates.");
+}
+
+void FragmentScheduler::recieveNotification(Observable *publisher, Notification_ptr notification)
+{
+  // we have an idle worker
+  if ((publisher == &pool) && (notification->getChannelNo() == WorkerPool::WorkerIdle)) {
+    LOG(1, "INFO: We are notified of an idle worker.");
+    // are jobs available?
+    if (JobsQueue.isJobPresent()) {
+      sendAvailableJobToNextIdleWorker();
+    }
+  }
+
+  // we have new jobs
+  if ((publisher == &JobsQueue) && (notification->getChannelNo() == FragmentQueue::JobAdded)) {
+    LOG(1, "INFO: We are notified of a new job.");
+    // check for idle workers
+    if (pool.presentIdleWorkers()) {
+      sendAvailableJobToNextIdleWorker();
+    }
+  }
+}
+
+void FragmentScheduler::subjectKilled(Observable *publisher)
+{}