source: src/Actions/WorldAction/RepeatBoxAction.cpp@ bcfb77

Action_Thermostats Add_AtomRandomPerturbation Add_FitFragmentPartialChargesAction Add_RotateAroundBondAction Add_SelectAtomByNameAction Added_ParseSaveFragmentResults AddingActions_SaveParseParticleParameters Adding_Graph_to_ChangeBondActions Adding_MD_integration_tests Adding_ParticleName_to_Atom Adding_StructOpt_integration_tests AtomFragments Automaking_mpqc_open AutomationFragmentation_failures Candidate_v1.5.4 Candidate_v1.6.0 Candidate_v1.6.1 ChangeBugEmailaddress ChangingTestPorts ChemicalSpaceEvaluator CombiningParticlePotentialParsing Combining_Subpackages Debian_Package_split Debian_package_split_molecuildergui_only Disabling_MemDebug Docu_Python_wait EmpiricalPotential_contain_HomologyGraph EmpiricalPotential_contain_HomologyGraph_documentation Enable_parallel_make_install Enhance_userguide Enhanced_StructuralOptimization Enhanced_StructuralOptimization_continued Example_ManyWaysToTranslateAtom Exclude_Hydrogens_annealWithBondGraph FitPartialCharges_GlobalError Fix_BoundInBox_CenterInBox_MoleculeActions Fix_ChargeSampling_PBC Fix_ChronosMutex Fix_FitPartialCharges Fix_FitPotential_needs_atomicnumbers Fix_ForceAnnealing Fix_IndependentFragmentGrids Fix_ParseParticles Fix_ParseParticles_split_forward_backward_Actions Fix_PopActions Fix_QtFragmentList_sorted_selection Fix_Restrictedkeyset_FragmentMolecule Fix_StatusMsg Fix_StepWorldTime_single_argument Fix_Verbose_Codepatterns Fix_fitting_potentials Fixes ForceAnnealing_goodresults ForceAnnealing_oldresults ForceAnnealing_tocheck ForceAnnealing_with_BondGraph ForceAnnealing_with_BondGraph_continued ForceAnnealing_with_BondGraph_continued_betteresults ForceAnnealing_with_BondGraph_contraction-expansion FragmentAction_writes_AtomFragments FragmentMolecule_checks_bonddegrees GeometryObjects Gui_Fixes Gui_displays_atomic_force_velocity ImplicitCharges IndependentFragmentGrids IndependentFragmentGrids_IndividualZeroInstances IndependentFragmentGrids_IntegrationTest IndependentFragmentGrids_Sole_NN_Calculation JobMarket_RobustOnKillsSegFaults JobMarket_StableWorkerPool JobMarket_unresolvable_hostname_fix MoreRobust_FragmentAutomation ODR_violation_mpqc_open PartialCharges_OrthogonalSummation PdbParser_setsAtomName PythonUI_with_named_parameters QtGui_reactivate_TimeChanged_changes Recreated_GuiChecks Rewrite_FitPartialCharges RotateToPrincipalAxisSystem_UndoRedo SaturateAtoms_findBestMatching SaturateAtoms_singleDegree StoppableMakroAction Subpackage_CodePatterns Subpackage_JobMarket Subpackage_LinearAlgebra Subpackage_levmar Subpackage_mpqc_open Subpackage_vmg Switchable_LogView ThirdParty_MPQC_rebuilt_buildsystem TrajectoryDependenant_MaxOrder TremoloParser_IncreasedPrecision TremoloParser_MultipleTimesteps TremoloParser_setsAtomName Ubuntu_1604_changes stable
Last change on this file since bcfb77 was 9d613f, checked in by Frederik Heber <heber@…>, 13 years ago

FIX: RepeatBoxAction did not use CopyMolecule() but copied by hand. Kudos: Gregor Bollerhey.

  • this causes trouble with FormatParsers such as Tremolo... who have internally additional information stored.
  • extended regression tests Domain/RepeatBox with a test of a repeated .data file with "special" element names.

Kudos to Gregor Bollerhey for finding this bug.

  • Property mode set to 100644
File size: 5.3 KB
Line 
1/*
2 * Project: MoleCuilder
3 * Description: creates and alters molecular systems
4 * Copyright (C) 2010 University of Bonn. All rights reserved.
5 * Please see the LICENSE file or "Copyright notice" in builder.cpp for details.
6 */
7
8/*
9 * RepeatBoxAction.cpp
10 *
11 * Created on: May 12, 2010
12 * Author: heber
13 */
14
15// include config.h
16#ifdef HAVE_CONFIG_H
17#include <config.h>
18#endif
19
20#include "CodePatterns/MemDebug.hpp"
21
22#include "Descriptors/MoleculePtrDescriptor.hpp"
23#include "atom.hpp"
24#include "CodePatterns/Log.hpp"
25#include "molecule.hpp"
26#include "MoleculeListClass.hpp"
27#include "LinearAlgebra/Vector.hpp"
28#include "LinearAlgebra/RealSpaceMatrix.hpp"
29#include "CodePatterns/Verbose.hpp"
30#include "World.hpp"
31#include "Box.hpp"
32
33#include <iostream>
34#include <set>
35#include <string>
36#include <vector>
37
38#include "Actions/WorldAction/RepeatBoxAction.hpp"
39
40using namespace MoleCuilder;
41
42// and construct the stuff
43#include "RepeatBoxAction.def"
44#include "Action_impl_pre.hpp"
45/** =========== define the function ====================== */
46
47void repeatMoleculesinDomain(Vector Repeater, const std::vector<molecule *> &AllMolecules)
48{
49 LOG(0, "STATUS: Repeating box " << Repeater << " times for (x,y,z) axis.");
50
51 // set new domain
52 RealSpaceMatrix M = World::getInstance().getDomain().getM();
53 RealSpaceMatrix newM = M;
54 Vector x,y;
55 int n[NDIM];
56 RealSpaceMatrix repMat;
57 for (int axis = 0; axis < NDIM; axis++) {
58 Repeater[axis] = floor(Repeater[axis]);
59 if (Repeater[axis] < 1) {
60 ELOG(1, "Repetition factor must be greater than 1!");
61 Repeater[axis] = 1;
62 }
63 repMat.at(axis,axis) = Repeater[axis];
64 }
65 newM *= repMat;
66 World::getInstance().setDomain(newM);
67
68 // add molecules in each repeated domain part
69 molecule *newmol = NULL;
70 std::vector<Vector> vectors;
71 MoleculeListClass *molecules = World::getInstance().getMolecules();
72 for (n[0] = 0; n[0] < Repeater[0]; n[0]++) {
73 y[0] = n[0];
74 for (n[1] = 0; n[1] < Repeater[1]; n[1]++) {
75 y[1] = n[1];
76 for (n[2] = 0; n[2] < Repeater[2]; n[2]++) {
77 y[2] = n[2];
78 if ((n[0] == 0) && (n[1] == 0) && (n[2] == 0))
79 continue;
80 for (vector<molecule *>::const_iterator MolRunner = AllMolecules.begin(); MolRunner != AllMolecules.end(); ++MolRunner) {
81 molecule * const mol = *MolRunner;
82 DoLog(1) && (Log() << Verbose(1) << "Current mol is " << mol->name << "." << endl);
83 newmol = mol->CopyMolecule();
84 // TODO: remove this when World does not have MoleculeListClass anymore.
85 molecules->insert(newmol);
86 x = y;
87 x *= M;
88 // shift each atom into new position
89 for(molecule::iterator iter = newmol->begin(); iter != newmol->end(); ++iter)
90 (*iter)->setPosition((*iter)->getPosition() + x);
91 }
92 }
93 }
94 }
95}
96
97Action::state_ptr WorldRepeatBoxAction::performCall() {
98 // obtain information
99 getParametersfromValueStorage();
100
101 std::vector<molecule *> AllMolecules;
102 DoLog(0) && (Log() << Verbose(0) << "Using all molecules." << endl);
103 AllMolecules = World::getInstance().getAllMolecules();
104
105 // prepare undo state
106 RealSpaceMatrix olddomain = World::getInstance().getDomain().getM();
107 std::set<molecule *> oldmolecules;
108 for(std::vector<molecule *>::const_iterator iter = AllMolecules.begin();
109 iter != AllMolecules.end();
110 ++iter)
111 oldmolecules.insert(*iter);
112 WorldRepeatBoxState *undostate = new WorldRepeatBoxState(olddomain, oldmolecules, params);
113
114 repeatMoleculesinDomain(params.Repeater, AllMolecules);
115
116 // give final box size
117 LOG(0, "Box domain is now " << World::getInstance().getDomain().getM());
118
119 return Action::state_ptr(undostate);
120}
121
122Action::state_ptr WorldRepeatBoxAction::performUndo(Action::state_ptr _state) {
123 WorldRepeatBoxState *state = assert_cast<WorldRepeatBoxState*>(_state.get());
124 MoleculeListClass *molecules = World::getInstance().getMolecules();
125
126 // set old domain
127 World::getInstance().setDomain(state->olddomain);
128
129 // remove all added molecules (and their atoms)
130 std::vector<molecule *> allmolecules = World::getInstance().getAllMolecules();
131 for (std::vector<molecule *>::iterator iter = allmolecules.begin();
132 iter != allmolecules.end();
133 ++iter) {
134 if (state->oldmolecules.find(*iter) == state->oldmolecules.end()) {
135 (*iter)->removeAtomsinMolecule();
136 // TODO: Remove this when World don't has deprecated MoleculeListClass anymore
137 molecules->erase(*iter);
138 World::getInstance().destroyMolecule(*iter);
139 }
140 }
141
142 // give final box size
143 LOG(0, "Box domain restored to " << World::getInstance().getDomain().getM());
144
145 return Action::state_ptr(_state);
146}
147
148Action::state_ptr WorldRepeatBoxAction::performRedo(Action::state_ptr _state){
149 WorldRepeatBoxState *state = assert_cast<WorldRepeatBoxState*>(_state.get());
150
151 std::vector<molecule *> originalmolecules;
152 for(std::set<molecule *>::const_iterator iter = state->oldmolecules.begin();
153 iter != state->oldmolecules.end();
154 ++iter)
155 originalmolecules.push_back(*iter);
156 repeatMoleculesinDomain(state->params.Repeater, originalmolecules);
157
158 // give final box size
159 LOG(0, "Box domain is again " << World::getInstance().getDomain().getM());
160
161 return Action::state_ptr(_state);
162}
163
164bool WorldRepeatBoxAction::canUndo() {
165 return true;
166}
167
168bool WorldRepeatBoxAction::shouldUndo() {
169 return true;
170}
171/** =========== end of function ====================== */
Note: See TracBrowser for help on using the repository browser.