Changeset e4afb4 for src/unittests

Timestamp:

Oct 30, 2010, 8:42:44 PM (14 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

76cec6, c38826

Parents:

23359f

git-author:

Frederik Heber <heber@…> (10/30/10 19:55:54)

git-committer:

Frederik Heber <heber@…> (10/30/10 20:42:44)

Message:

Huge refactoring: Introduction of Traits to Actions.

This change is really big but the introduction of the Trait concept (at least
in its current light form) is so fundamental that lots of pieces had to be
changed in order to get everything working.

The main point why it was necessary to add these traits in the first place was
to comfortably allow for adding extension of Actions information-wise, i.e.
with stuff that is only important for the QtUI, such as icons, or tooltips, ...
This extra information should not be stored with Action itself, as it has
nothing to do with the workings of the Action. And neither should it get
stored with some blown-out-of-proportions MapOfActions class ...

The gist of the change is as follows:

• OptionTrait contains the token, description, shortform and type of an option, such as ("position", "position in space, none, typeid(Vector)).
• ActionTrait is the derived form for actions where additionally MenuPosition and MenuName are stored (and probably more to come for the GUI), also we have a set of OptionTrait instances, one for each option of the Action.
• Action then contains this ActionTrait, specialized for each Action.
• the preprocessor macros have been enhanced to gather all this information from the .def files.
• MapOfActions is gone. Completely. Most of its use was to store this extra information and the ValueStorage part now is just in class ValueStorage.
• ValueStorage is no more an interface to MapOfActions but as the name says a (type-safe) ValueStorage.

Listing the (remaining) changes in alphabetical order of the class:

• Action
  • member value ::name dropped, ::getName() uses ActionTraits::getName()
  • new define NODEFAULT which is used in paramdefaults in .def files
  • all derived actions classes such as Process, Calculations, MakroAction,... have been adapated to use the ActionTrait concept as well.

• ActionHistory
  • extraced RedoAction and UndoAction, shifted implementation into their own object files and they use .def files as well (i.e. streamlined with method used for other actions)

• CommandLineParser
  • CommandLineParser goes through ActionRegistry to get arguments and types to add
  • we use TypeEnumContainer which before was present in MapOfActions, as CommandLineParser::AddOptionsToParser() needs enums in its switch statement, we can't switch on types and types are not known until run-time. Hence, templates won't do either.
  • ShortFormMap is created here now (and used here only)
  • File was moved over to UIElements/CommandLineUI.

• MenuDescription
  • contain information on Menus such as name, ...
  • new unit test checks for consistency

• molecule
  • const member functions: Copy(), Output() and OutputBonds()

• OptionRegistry
  • new registry class for options only
  • we want the same type throughout the code for each token, e.g. "position"
  • the registry containts checks for consistency

• OptionTrait
  • default values are specified in paramdefaults, none are given by NODEFAULT
  • introduced default for translate-atoms, point-correlation, pair-correlation

• Registry pattern
  • new unit test, but only sceleton code so far

• ...Query, also ...Pipe
  • atoms, molecule and elements are now all const
  • also ValueStorage's signatures all have const therein

• ValueStorage
  • set/queryCurrentValue from MapOfActions
  • at times VectorValue has been in .def files where Vector was in the signature. This is cleared. Such stuff is only present for e.g. BoxVector being queried as a Vector. But this is a feature and intended.

• World
  • most of the (un)selection functions now work on const atoms and molecules
  • in one case we need a const_cast to remove this, but this is intentional, as the vector of selected atoms stores non-const pointers and this is ok.

There is only one test which had to be changed slightly because a specific
option token as "position" must now have the same type everywhere, e.g. always
Vector.

• TESTFIX: Simple_configuration/2: --position -> --domain-position (and associated to BoxVector)

Location:

src/unittests

Files:

• ActionSequenceTest.cpp (modified) (5 diffs)
• Makefile.am (modified) (4 diffs)
• MenuDescriptionUnitTest.cpp (modified) (3 diffs)
• MenuDescriptionUnitTest.hpp (modified) (5 diffs)
• RegistryUnitTest.cpp (added)
• RegistryUnitTest.hpp (added)
• atomsCalculationTest.cpp (modified) (3 diffs)

src/unittests/ActionSequenceTest.cpp

@@ -44 +44 @@
 {
 public:
-  canUndoActionStub(): Action("canUndoActionStub",false){}
+  canUndoActionStub(const ActionTraits &_trait):
+    Action(_trait,false){}
   virtual ~canUndoActionStub(){}
 
@@ -75 +76 @@
 {
 public:
-  cannotUndoActionStub() : Action("cannotUndoActionStub",false){}
+  cannotUndoActionStub(const ActionTraits &_trait) :
+    Action(_trait,false){}
   virtual ~cannotUndoActionStub(){}
 
@@ -106 +108 @@
 {
 public:
-  wasCalledActionStub() :
-      Action("wasCalledActionStub",false),
+  wasCalledActionStub(const ActionTraits &_trait) :
+      Action(_trait,false),
       called(false)
   {}
@@ -153 +155 @@
   UIFactory::makeUserInterface("Dummy");
   // create some necessary stubs used in this test
-  positive1 = new canUndoActionStub();
-  positive2 = new canUndoActionStub();
-  negative1 = new cannotUndoActionStub();
-  negative2 = new cannotUndoActionStub();
-
-  shouldCall1 = new wasCalledActionStub();
-  shouldCall2 = new wasCalledActionStub();
-  shouldNotCall1 = new wasCalledActionStub();
-  shouldNotCall2 = new wasCalledActionStub();
+  ActionTraits canUndoTrait("canUndoActionStub");
+  ActionTraits cannotUndoTrait("cannotUndoActionStub");
+  positive1 = new canUndoActionStub(canUndoTrait);
+  positive2 = new canUndoActionStub(canUndoTrait);
+  negative1 = new cannotUndoActionStub(cannotUndoTrait);
+  negative2 = new cannotUndoActionStub(cannotUndoTrait);
+
+  ActionTraits wasCalledTrait("wasCalledActionStub");
+  shouldCall1 = new wasCalledActionStub(wasCalledTrait);
+  shouldCall2 = new wasCalledActionStub(wasCalledTrait);
+  shouldNotCall1 = new wasCalledActionStub(wasCalledTrait);
+  shouldNotCall2 = new wasCalledActionStub(wasCalledTrait);
 
 }
@@ -254 +259 @@
 void ActionSequenceTest::doesUndoTest(){
   ActionSequence *sequence = new ActionSequence();
-  wasCalledActionStub *wasCalled1 = new wasCalledActionStub();
-  wasCalledActionStub *wasCalled2 = new wasCalledActionStub();
+  ActionTraits wasCalledTrait("wasCalledActionStub");
+  wasCalledActionStub *wasCalled1 = new wasCalledActionStub(wasCalledTrait);
+  wasCalledActionStub *wasCalled2 = new wasCalledActionStub(wasCalledTrait);
   sequence->addAction(wasCalled1);
   sequence->addAction(wasCalled2);
 
-  MakroAction act("Test MakroAction",sequence,false);
+  ActionTraits MakroTrait("Test MakroAction");
+  MakroAction act(MakroTrait,sequence,false);
 
   act.call();

src/unittests/Makefile.am

@@ -38 +38 @@
   periodentafelTest \
   PlaneUnittest \
+  Registry \
   ShapeUnittest \
   SingletonTest \
@@ -97 +98 @@
   periodentafelTest.cpp \
   PlaneUnittest.cpp \
+  RegistryUnitTest.cpp \
   ShapeUnittest.cpp \
   SingletonTest.cpp \
@@ -132 +134 @@
   MenuDescriptionUnitTest.hpp \
   MoleculeDescriptorTest.hpp \
+  ObserverTest.hpp \
   periodentafelTest.hpp \
   ParserUnitTest.hpp \
   PlaneUnittest.hpp \
-  ObserverTest.hpp \
+  RegistryUnitTest.hpp \
   SingletonTest.hpp \
   stackclassunittest.hpp \
@@ -234 +237 @@
 PlaneUnittest_LDADD = ${ALLLIBS}
 
+Registry_SOURCES = UnitTestMain.cpp RegistryUnitTest.cpp RegistryUnitTest.hpp
+Registry_LDADD = ${ALLLIBS}
+
 ShapeUnittest_SOURCES = UnitTestMain.cpp ShapeUnittest.cpp ShapeUnittest.hpp
 ShapeUnittest_LDADD = ${ALLLIBS}

src/unittests/MenuDescriptionUnitTest.cpp

@@ -7 +7 @@
 
 /*
- * InfoUnitTest.cpp
+ * MenuDescriptionUnitTest.cpp
  *
  *  Created on: Nov 25, 2009
@@ -45 +45 @@
 };
 
-/** UnitTest for SensibilityTest().
+/** UnitTest for consistency.
+ * we check that we have the same keys in each of MenuSet, MenuDescription and MenuNameMap.
  */
-void MenuDescriptionTest::SensibilityTest()
+void MenuDescriptionTest::ConsistencyCheck()
 {
   // from MenuSet
@@ -63 +64 @@
   // from MenuNameMap
   for(std::map<std::string, std::string>::const_iterator iter = md.MenuNameMap.begin(); iter != md.MenuNameMap.end(); ++iter) {
-    CPPUNIT_ASSERT_MESSAGE( "menu token not contained in MenuDescription::MenuDewscriptionsMap", md.MenuDescriptionsMap.find(iter->first) != md.MenuDescriptionsMap.end());
+    CPPUNIT_ASSERT_MESSAGE( "menu token not contained in MenuDescription::MenuDescriptionsMap", md.MenuDescriptionsMap.find(iter->first) != md.MenuDescriptionsMap.end());
     CPPUNIT_ASSERT_MESSAGE( "menu token not contained in MenuDescription::MenuSet", md.MenuSet.find(iter->first) != md.MenuSet.end());
   }

src/unittests/MenuDescriptionUnitTest.hpp

@@ -1 +1 @@
 /*
- * InfoUnitTest.hpp
+ * MenuDescriptionUnitTest.cpp.hpp
  *
  *  Created on: Nov 25, 2009
@@ -6 +6 @@
  */
 
-#ifndef INFOUNITTEST_HPP_
-#define INFOUNITTEST_HPP_
+#ifndef MENUDESCRIPTORUNITTEST_HPP_
+#define MENUDESCRIPTORUNITTEST_HPP_
 
 #include <cppunit/extensions/HelperMacros.h>
@@ -18 +18 @@
 {
     CPPUNIT_TEST_SUITE( MenuDescriptionTest) ;
-    CPPUNIT_TEST ( SensibilityTest );
+    CPPUNIT_TEST ( ConsistencyCheck );
     CPPUNIT_TEST_SUITE_END();
 
@@ -24 +24 @@
       void setUp();
       void tearDown();
-      void SensibilityTest();
+      void ConsistencyCheck();
 
 private:
@@ -30 +30 @@
 };
 
-#endif /* INFOUNITTEST_HPP_ */
+#endif /* MENUDESCRIPTORUNITTEST_HPP_ */

src/unittests/atomsCalculationTest.cpp

@@ -31 +31 @@
 #include "Actions/AtomsCalculation_impl.hpp"
 #include "Actions/ActionRegistry.hpp"
+#include "Actions/ActionTraits.hpp"
 
 #include "World.hpp"
@@ -88 +89 @@
 
 void atomsCalculationTest::testCalculateSimple(){
-  AtomsCalculation<atomId_t> *calc = World::getInstance().calcOnAtoms<atomId_t>(boost::bind(&atom::getId,_1),"FOO",AllAtoms());
+  ActionTraits FooTrait("FOO");
+  AtomsCalculation<atomId_t> *calc = World::getInstance().calcOnAtoms<atomId_t>(boost::bind(&atom::getId,_1),FooTrait,AllAtoms());
   std::vector<atomId_t> allIds = (*calc)();
   CPPUNIT_ASSERT(hasAllIds(allIds,atomIds));
@@ -95 +97 @@
 
 void atomsCalculationTest::testCalculateExcluded(){
+  ActionTraits FooTrait("FOO");
   atomId_t excluded = atomIds[ATOM_COUNT/2];
-  AtomsCalculation<atomId_t> *calc = World::getInstance().calcOnAtoms<atomId_t>(boost::bind(&atom::getId,_1),"FOO",AllAtoms() && !AtomById(excluded));
+  AtomsCalculation<atomId_t> *calc = World::getInstance().calcOnAtoms<atomId_t>(boost::bind(&atom::getId,_1),FooTrait,AllAtoms() && !AtomById(excluded));
   std::vector<atomId_t> allIds = (*calc)();
   std::set<atomId_t> excluded_set;