Changeset e4afb4 for src/Actions/AtomAction

Timestamp:

Oct 30, 2010, 8:42:44 PM (15 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

76cec6, c38826

Parents:

23359f

git-author:

Frederik Heber <heber@…> (10/30/10 19:55:54)

git-committer:

Frederik Heber <heber@…> (10/30/10 20:42:44)

Message:

Huge refactoring: Introduction of Traits to Actions.

This change is really big but the introduction of the Trait concept (at least
in its current light form) is so fundamental that lots of pieces had to be
changed in order to get everything working.

The main point why it was necessary to add these traits in the first place was
to comfortably allow for adding extension of Actions information-wise, i.e.
with stuff that is only important for the QtUI, such as icons, or tooltips, ...
This extra information should not be stored with Action itself, as it has
nothing to do with the workings of the Action. And neither should it get
stored with some blown-out-of-proportions MapOfActions class ...

The gist of the change is as follows:

• OptionTrait contains the token, description, shortform and type of an option, such as ("position", "position in space, none, typeid(Vector)).
• ActionTrait is the derived form for actions where additionally MenuPosition and MenuName are stored (and probably more to come for the GUI), also we have a set of OptionTrait instances, one for each option of the Action.
• Action then contains this ActionTrait, specialized for each Action.
• the preprocessor macros have been enhanced to gather all this information from the .def files.
• MapOfActions is gone. Completely. Most of its use was to store this extra information and the ValueStorage part now is just in class ValueStorage.
• ValueStorage is no more an interface to MapOfActions but as the name says a (type-safe) ValueStorage.

Listing the (remaining) changes in alphabetical order of the class:

• Action
  • member value ::name dropped, ::getName() uses ActionTraits::getName()
  • new define NODEFAULT which is used in paramdefaults in .def files
  • all derived actions classes such as Process, Calculations, MakroAction,... have been adapated to use the ActionTrait concept as well.

• ActionHistory
  • extraced RedoAction and UndoAction, shifted implementation into their own object files and they use .def files as well (i.e. streamlined with method used for other actions)

• CommandLineParser
  • CommandLineParser goes through ActionRegistry to get arguments and types to add
  • we use TypeEnumContainer which before was present in MapOfActions, as CommandLineParser::AddOptionsToParser() needs enums in its switch statement, we can't switch on types and types are not known until run-time. Hence, templates won't do either.
  • ShortFormMap is created here now (and used here only)
  • File was moved over to UIElements/CommandLineUI.

• MenuDescription
  • contain information on Menus such as name, ...
  • new unit test checks for consistency

• molecule
  • const member functions: Copy(), Output() and OutputBonds()

• OptionRegistry
  • new registry class for options only
  • we want the same type throughout the code for each token, e.g. "position"
  • the registry containts checks for consistency

• OptionTrait
  • default values are specified in paramdefaults, none are given by NODEFAULT
  • introduced default for translate-atoms, point-correlation, pair-correlation

• Registry pattern
  • new unit test, but only sceleton code so far

• ...Query, also ...Pipe
  • atoms, molecule and elements are now all const
  • also ValueStorage's signatures all have const therein

• ValueStorage
  • set/queryCurrentValue from MapOfActions
  • at times VectorValue has been in .def files where Vector was in the signature. This is cleared. Such stuff is only present for e.g. BoxVector being queried as a Vector. But this is a feature and intended.

• World
  • most of the (un)selection functions now work on const atoms and molecules
  • in one case we need a const_cast to remove this, but this is intentional, as the vector of selected atoms stores non-const pointers and this is ok.

There is only one test which had to be changed slightly because a specific
option token as "position" must now have the same type everywhere, e.g. always
Vector.

• TESTFIX: Simple_configuration/2: --position -> --domain-position (and associated to BoxVector)

Location:

src/Actions/AtomAction

Files:

• AddAction.cpp (modified) (1 diff)
• AddAction.def (modified) (2 diffs)
• ChangeElementAction.cpp (modified) (1 diff)
• ChangeElementAction.def (modified) (2 diffs)
• RemoveAction.cpp (modified) (1 diff)
• RemoveAction.def (modified) (2 diffs)
• RotateAroundOriginByAngleAction.cpp (modified) (1 diff)
• RotateAroundOriginByAngleAction.def (modified) (2 diffs)
• TranslateAction.cpp (modified) (1 diff)
• TranslateAction.def (modified) (2 diffs)

src/Actions/AtomAction/AddAction.cpp

@@ -93 +93 @@
   return true;
 }
-
-const string AtomAddAction::getName() {
-  return NAME;
-}
 /** =========== end of function ====================== */

src/Actions/AtomAction/AddAction.def

@@ -13 +13 @@
 // i.e. there is an integer with variable name Z that can be found in
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
-// "undefine" if no parameters are required
+// "undefine" if no parameters are required, use (NODEFAULT) for each (undefined) default value
 #define paramtypes (const element *)(BoxVector)
-#define paramtokens ("add-atom")("position")
-#define paramdescriptions ("add atom of specified element")("position in R^3 space")
+#define paramtokens ("add-atom")("domain-position")
+#define paramdescriptions ("element of new atom")("position within current domain")
 #define paramreferences (elemental)(position)
+#define paramdefaults (NODEFAULT)(NODEFAULT)
 
 #define statetypes (const atomId_t)
@@ -30 +31 @@
 
 // finally the information stored in the ActionTrait specialization
-#undef DEFAULTVALUE
 #define DESCRIPTION "add atom of specified element"
 #define SHORTFORM "a"
-#define TYPEINFO &typeid(const element)

src/Actions/AtomAction/ChangeElementAction.cpp

@@ -105 +105 @@
   return true;
 }
-
-const string AtomChangeElementAction::getName() {
-  return NAME;
-}
 /** =========== end of function ====================== */

src/Actions/AtomAction/ChangeElementAction.def

@@ -12 +12 @@
 // i.e. there is an integer with variable name Z that can be found in
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
-// "undefine" if no parameters are required
+// "undefine" if no parameters are required, use (NODEFAULT) for each (undefined) default value
 #define paramtypes (const element *)
 #define paramtokens ("change-element")
-#define paramdescriptions ("change the element of an atom")
+#define paramdescriptions ("new the element of atom")
+#undef paramdefaults
 #define paramreferences (elemental)
 
@@ -29 +30 @@
 
 // finally the information stored in the ActionTrait specialization
-#undef DEFAULTVALUE
 #define DESCRIPTION "change the element of an atom"
 #define SHORTFORM "E"
-#define TYPEINFO &typeid(const element)

src/Actions/AtomAction/RemoveAction.cpp

@@ -107 +107 @@
   return true;
 }
-
-const string AtomRemoveAction::getName() {
-  return NAME;
-}
 /** =========== end of function ====================== */

src/Actions/AtomAction/RemoveAction.def

@@ -11 +11 @@
 // i.e. there is an integer with variable name Z that can be found in
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
-// "undefine" if no parameters are required
+// "undefine" if no parameters are required, use (NODEFAULT) for each (undefined) default value
 #undef paramtypes
 #undef paramtokens
 #undef paramdescriptions
+#undef paramdefaults
 #undef paramreferences
 
@@ -29 +30 @@
 
 // finally the information stored in the ActionTrait specialization
-#undef DEFAULTVALUE
 #define DESCRIPTION "remove a specified atom"
 #define SHORTFORM "r"
-#define TYPEINFO &typeid(void)

src/Actions/AtomAction/RotateAroundOriginByAngleAction.cpp

@@ -98 +98 @@
   return true;
 }
-
-const string AtomRotateAroundOriginByAngleAction::getName() {
-  return NAME;
-}
 /** =========== end of function ====================== */

src/Actions/AtomAction/RotateAroundOriginByAngleAction.def

@@ -11 +11 @@
 // i.e. there is an integer with variable name Z that can be found in
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
-// "undefine" if no parameters are required
+// "undefine" if no parameters are required, use (NODEFAULT) for each (undefined) default value
 #define paramtypes (double)(Vector)
 #define paramtokens ("rotate-origin")("position")
-#define paramdescriptions ("rotate selected atoms by a specific angle around origin")("position in R^3 space")
+#define paramdescriptions ("rotation angle")("position in R^3 space")
+#undef paramdefaults
 #define paramreferences (angle)(Axis)
 
@@ -29 +30 @@
 
 // finally the information stored in the ActionTrait specialization
-#undef DEFAULTVALUE
 #define DESCRIPTION "rotate selected atoms by a specific angle around origin"
 #undef SHORTFORM
-#define TYPEINFO &typeid(double)

src/Actions/AtomAction/TranslateAction.cpp

@@ -88 +88 @@
   return true;
 }
-
-const string AtomTranslateAction::getName() {
-  return NAME;
-}
 /** =========== end of function ====================== */

src/Actions/AtomAction/TranslateAction.def

@@ -12 +12 @@
 // i.e. there is an integer with variable name Z that can be found in
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
-// "undefine" if no parameters are required
+// "undefine" if no parameters are required, use (NODEFAULT) for each (undefined) default value
 #define paramtypes (Vector)(bool)
 #define paramtokens ("translate-atoms")("periodic")
-#define paramdescriptions ("translate all selected atoms by given vector")("system is constraint to periodic boundary conditions")
+#define paramdescriptions ("translation vector")("system is constraint to periodic boundary conditions")
 #define paramreferences (x)(periodic)
+#define paramdefaults (NODEFAULT)("0")
 
 #define statetypes (std::vector<atom*>)
@@ -30 +31 @@
 
 // finally the information stored in the ActionTrait specialization
-#undef DEFAULTVALUE
 #define DESCRIPTION "translate all selected atoms by given vector"
 #define SHORTFORM "t"
-#define TYPEINFO &typeid(VectorValue)