Changeset d57341 for src/Actions/WorldAction

Timestamp:

Oct 30, 2010, 7:22:34 PM (14 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

8bcf3f

Parents:

052bfd8

git-author:

Frederik Heber <heber@…> (10/26/10 13:56:46)

git-committer:

Frederik Heber <heber@…> (10/30/10 19:22:34)

Message:

Replaced ACTION::NAME in .def files by contents DESCRPTION.

• in ActionTrait constructor we cannot access Action (i.e. NAME)
• also, this is inconsistent and errorprone
  • ACTION::NAME has to be remembered as the shortform for an Action beloning to the action
  • ACTION may be spelled out and thus also mis-spelled.
• conversion script contained in src/Actions/convert4.sh.

Location:

src/Actions/WorldAction

Files:

• AddEmptyBoundaryAction.def (modified) (1 diff)
• CenterInBoxAction.def (modified) (1 diff)
• ChangeBoxAction.def (modified) (1 diff)
• InputAction.def (modified) (1 diff)
• RepeatBoxAction.def (modified) (1 diff)
• ScaleBoxAction.def (modified) (1 diff)
• SetDefaultNameAction.def (modified) (1 diff)
• SetGaussianBasisAction.def (modified) (1 diff)
• SetOutputFormatsAction.def (modified) (1 diff)

src/Actions/WorldAction/AddEmptyBoundaryAction.def

@@ -14 +14 @@
 // "undefine" if no parameters are required
 #define paramtypes (Vector)
-#define paramtokens (WorldAddEmptyBoundaryAction::NAME)
+#define paramtokens ("boundary")
 #define paramdescriptions ("change box to add an empty boundary around all atoms")
 #define paramreferences (boundary)

src/Actions/WorldAction/CenterInBoxAction.def

@@ -14 +14 @@
 // "undefine" if no parameters are required
 #define paramtypes (Box)
-#define paramtokens (WorldCenterInBoxAction::NAME)
+#define paramtokens ("center-in-box")
 #define paramdescriptions ("center all atoms in the domain")
 #define paramreferences (cell_size)

src/Actions/WorldAction/ChangeBoxAction.def

@@ -14 +14 @@
 // "undefine" if no parameters are required
 #define paramtypes (Box)
-#define paramtokens (WorldChangeBoxAction::NAME)
+#define paramtokens ("change-box")
 #define paramdescriptions ("change the symmetrc matrix of the simulation domain")
 #define paramreferences (cell_size)

src/Actions/WorldAction/InputAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (boost::filesystem::path)
-#define paramtokens (WorldInputAction::NAME)
+#define paramtokens ("input")
 #define paramdescriptions ("specify input files")
 #define paramreferences (filename)

src/Actions/WorldAction/RepeatBoxAction.def

@@ -14 +14 @@
 // "undefine" if no parameters are required
 #define paramtypes (Vector)
-#define paramtokens (WorldRepeatBoxAction::NAME)
+#define paramtokens ("repeat-box")
 #define paramdescriptions ("create periodic copies of the simulation box per axis")
 #define paramreferences (Repeater)

src/Actions/WorldAction/ScaleBoxAction.def

@@ -14 +14 @@
 // "undefine" if no parameters are required
 #define paramtypes (Vector)
-#define paramtokens (WorldScaleBoxAction::NAME)
+#define paramtokens ("scale-box")
 #define paramdescriptions ("scale box and atomic positions inside")
 #define paramreferences (Scaler)

src/Actions/WorldAction/SetDefaultNameAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (std::string)
-#define paramtokens (WorldSetDefaultNameAction::NAME)
+#define paramtokens ("default-molname")
 #define paramdescriptions ("set the default name of new molecules")
 #define paramreferences (newname)

src/Actions/WorldAction/SetGaussianBasisAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (std::string)
-#define paramtokens (WorldSetGaussianBasisAction::NAME)
+#define paramtokens ("set-basis")
 #define paramdescriptions ("set the name of the gaussian basis set for MPQC")
 #define paramreferences (newname)

src/Actions/WorldAction/SetOutputFormatsAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (vector<std::string>)
-#define paramtokens (WorldSetOutputFormatsAction::NAME)
+#define paramtokens ("set-output")
 #define paramdescriptions ("specify output formats")
 #define paramreferences (FormatList)