Changeset d57341 for src/Actions/SelectionAction

Timestamp:

Oct 30, 2010, 7:22:34 PM (14 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

8bcf3f

Parents:

052bfd8

git-author:

Frederik Heber <heber@…> (10/26/10 13:56:46)

git-committer:

Frederik Heber <heber@…> (10/30/10 19:22:34)

Message:

Replaced ACTION::NAME in .def files by contents DESCRPTION.

• in ActionTrait constructor we cannot access Action (i.e. NAME)
• also, this is inconsistent and errorprone
  • ACTION::NAME has to be remembered as the shortform for an Action beloning to the action
  • ACTION may be spelled out and thus also mis-spelled.
• conversion script contained in src/Actions/convert4.sh.

Location:

src/Actions/SelectionAction

Files:

• AllAtomsInsideCuboidAction.def (modified) (1 diff)
• AllAtomsInsideSphereAction.def (modified) (1 diff)
• AllAtomsOfMoleculeAction.def (modified) (1 diff)
• AtomByElementAction.def (modified) (1 diff)
• AtomByIdAction.def (modified) (1 diff)
• MoleculeByFormulaAction.def (modified) (1 diff)
• MoleculeByIdAction.def (modified) (1 diff)
• MoleculeOfAtomAction.def (modified) (1 diff)
• NotAllAtomsInsideCuboidAction.def (modified) (1 diff)
• NotAllAtomsInsideSphereAction.def (modified) (1 diff)
• NotAllAtomsOfMoleculeAction.def (modified) (1 diff)
• NotAtomByElementAction.def (modified) (1 diff)
• NotAtomByIdAction.def (modified) (1 diff)
• NotMoleculeByFormulaAction.def (modified) (1 diff)
• NotMoleculeByIdAction.def (modified) (1 diff)
• NotMoleculeOfAtomAction.def (modified) (1 diff)

src/Actions/SelectionAction/AllAtomsInsideCuboidAction.def

@@ -14 +14 @@
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
 // "undefine" if no parameters are required
-#define paramtypes (Vector) (Vector) (double) (double) (double)
-#define paramtokens (SelectionAllAtomsInsideCuboidAction::NAME) ("position") ("angle-x") ("angle-y") ("angle-z")
-#define paramdescriptions ("select all atoms inside a cuboid") ("position in R^3 space") ("angle of a rotation around x axis") ("angle of a rotation around y axis") ("angle of a rotation around z axis")
-#define paramreferences (extension) (position) (Xangle) (Yangle) (Zangle)
+#define paramtypes (Vector)(Vector)(double)(double)(double)
+#define paramtokens ("select-atoms-inside-cuboid")("position")("angle-x")("angle-y")("angle-z")
+#define paramdescriptions ("select all atoms inside a cuboid")("position in R^3 space")("angle of a rotation around x axis")("angle of a rotation around y axis")("angle of a rotation around z axis")
+#define paramreferences (extension)(position)(Xangle)(Yangle)(Zangle)
 
 #define statetypes (std::vector<atom*>)

src/Actions/SelectionAction/AllAtomsInsideSphereAction.def

@@ -12 +12 @@
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
 // "undefine" if no parameters are required
-#define paramtypes (double) (Vector)
-#define paramtokens (SelectionAllAtomsInsideSphereAction::NAME) ("position")
-#define paramdescriptions ("select all atoms inside a sphere") ("position in R^3 space")
-#define paramreferences (radius) (position)
+#define paramtypes (double)(Vector)
+#define paramtokens ("select-atoms-inside-sphere")("position")
+#define paramdescriptions ("select all atoms inside a sphere")("position in R^3 space")
+#define paramreferences (radius)(position)
 
 #define statetypes (std::vector<atom*>)

src/Actions/SelectionAction/AllAtomsOfMoleculeAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (molecule *)
-#define paramtokens (SelectionAllAtomsOfMoleculeAction::NAME)
+#define paramtokens ("select-molecules-atoms")
 #define paramdescriptions ("select all atoms of a molecule")
 #define paramreferences (mol)

src/Actions/SelectionAction/AtomByElementAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (const element*)
-#define paramtokens (SelectionAtomByElementAction::NAME)
+#define paramtokens ("select-atom-by-element")
 #define paramdescriptions ("select an atom by element")
 #define paramreferences (elemental)

src/Actions/SelectionAction/AtomByIdAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (atom*)
-#define paramtokens (SelectionAtomByIdAction::NAME)
+#define paramtokens ("select-atom-by-id")
 #define paramdescriptions ("select an atom by index")
 #define paramreferences (Walker)

src/Actions/SelectionAction/MoleculeByFormulaAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (std::string)
-#define paramtokens (SelectionMoleculeByFormulaAction::NAME)
+#define paramtokens ("select-molecule-by-formula")
 #define paramdescriptions ("select a molecule by chemical formula")
 #define paramreferences (formula)

src/Actions/SelectionAction/MoleculeByIdAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (molecule*)
-#define paramtokens (SelectionMoleculeByIdAction::NAME)
+#define paramtokens ("select-molecule-by-id")
 #define paramdescriptions ("select a molecule by index")
 #define paramreferences (mol)

src/Actions/SelectionAction/MoleculeOfAtomAction.def

@@ -12 +12 @@
 // "undefine" if no parameters are required
 #define paramtypes (atom*)
-#define paramtokens (SelectionMoleculeOfAtomAction::NAME)
+#define paramtokens ("select-molecule-of-atom")
 #define paramdescriptions ("select a molecule to which a given atom belongs")
 #define paramreferences (Walker)

src/Actions/SelectionAction/NotAllAtomsInsideCuboidAction.def

@@ -14 +14 @@
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
 // "undefine" if no parameters are required
-#define paramtypes (Vector) (Vector) (double) (double) (double)
-#define paramtokens (SelectionNotAllAtomsInsideCuboidAction::NAME) ("position") ("angle-x") ("angle-y") ("angle-z")
-#define paramdescriptions ("unselect all atoms inside a cuboid") ("position in R^3 space") ("angle of a rotation around x axis") ("angle of a rotation around y axis") ("angle of a rotation around z axis")
-#define paramreferences (extension) (position) (Xangle) (Yangle) (Zangle)
+#define paramtypes (Vector)(Vector)(double)(double)(double)
+#define paramtokens ("unselect-atoms-inside-cuboid")("position")("angle-x")("angle-y")("angle-z")
+#define paramdescriptions ("unselect all atoms inside a cuboid")("position in R^3 space")("angle of a rotation around x axis")("angle of a rotation around y axis")("angle of a rotation around z axis")
+#define paramreferences (extension)(position)(Xangle)(Yangle)(Zangle)
 
 #define statetypes (std::vector<atom*>)

src/Actions/SelectionAction/NotAllAtomsInsideSphereAction.def

@@ -12 +12 @@
 // ValueStorage by the token "Z" -> first column: int, Z, "Z"
 // "undefine" if no parameters are required
-#define paramtypes (double) (Vector)
-#define paramtokens (SelectionNotAllAtomsInsideSphereAction::NAME) ("position")
-#define paramdescriptions ("unselect all atoms inside a sphere") ("position in R^3 space")
-#define paramreferences (radius) (position)
+#define paramtypes (double)(Vector)
+#define paramtokens ("unselect-atoms-inside-sphere")("position")
+#define paramdescriptions ("unselect all atoms inside a sphere")("position in R^3 space")
+#define paramreferences (radius)(position)
 
 #define statetypes (std::vector<atom*>)

src/Actions/SelectionAction/NotAllAtomsOfMoleculeAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (molecule*)
-#define paramtokens (SelectionNotAllAtomsOfMoleculeAction::NAME)
+#define paramtokens ("unselect-molecules-atoms")
 #define paramdescriptions ("unselect all atoms of a molecule")
 #define paramreferences (mol)

src/Actions/SelectionAction/NotAtomByElementAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (const element*)
-#define paramtokens (SelectionNotAtomByElementAction::NAME)
+#define paramtokens ("unselect-atom-by-element")
 #define paramdescriptions ("unselect an atom by element")
 #define paramreferences (elemental)

src/Actions/SelectionAction/NotAtomByIdAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (atom*)
-#define paramtokens (SelectionNotAtomByIdAction::NAME)
+#define paramtokens ("unselect-atom-by-id")
 #define paramdescriptions ("unselect an atom by index")
 #define paramreferences (Walker)

src/Actions/SelectionAction/NotMoleculeByFormulaAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (std::string)
-#define paramtokens (SelectionNotMoleculeByFormulaAction::NAME)
+#define paramtokens ("unselect-molecule-by-formula")
 #define paramdescriptions ("unselect a molecule by chemical formula")
 #define paramreferences (formula)

src/Actions/SelectionAction/NotMoleculeByIdAction.def

@@ -13 +13 @@
 // "undefine" if no parameters are required
 #define paramtypes (molecule*)
-#define paramtokens (SelectionNotMoleculeByIdAction::NAME)
+#define paramtokens ("unselect-molecule-by-id")
 #define paramdescriptions ("unselect a molecule by index")
 #define paramreferences (mol)

src/Actions/SelectionAction/NotMoleculeOfAtomAction.def

@@ -12 +12 @@
 // "undefine" if no parameters are required
 #define paramtypes (atom*)
-#define paramtokens (SelectionNotMoleculeOfAtomAction::NAME)
+#define paramtokens ("unselect-molecule-of-atom")
 #define paramdescriptions ("unselect a molecule to which a given atom belongs")
 #define paramreferences (Walker)