Changeset d3e1d5 for src/FunctionApproximation

Timestamp:

Apr 10, 2018, 6:43:29 AM (7 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

AutomationFragmentation_failures, Candidate_v1.6.1, ChemicalSpaceEvaluator, Exclude_Hydrogens_annealWithBondGraph, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_contraction-expansion, Gui_displays_atomic_force_velocity, PythonUI_with_named_parameters, StoppableMakroAction, TremoloParser_IncreasedPrecision

Children:

e77580

Parents:

e21d55

git-author:

Frederik Heber <frederik.heber@…> (07/18/17 21:42:07)

git-committer:

Frederik Heber <frederik.heber@…> (04/10/18 06:43:29)

Message:

FIX: unnecessary output iterator present in FunctionaApproximation::evaluate().

File:

• src/FunctionApproximation/FunctionApproximation.cpp (modified) (4 diffs)

src/FunctionApproximation/FunctionApproximation.cpp

@@ -134 +134 @@
     p = new double[m];
     size_t index = 0;
+    // cannot use std::copy here because of additional dereference
     for(FunctionModel::parameters_t::const_iterator paramiter = params.begin();
         paramiter != params.end();
@@ -148 +149 @@
     x = new double[n];
     size_t index = 0;
+    // cannot use std::copy here because of additional dereference
     for(outputs_t::const_iterator outiter = output_data.begin();
         outiter != output_data.end();
@@ -341 +343 @@
   if (!output_data.empty()) {
     filtered_inputs_t::const_iterator initer = input_data.begin();
-    outputs_t::const_iterator outiter = output_data.begin();
+//    outputs_t::const_iterator outiter = output_data.begin();
     size_t index = 0;
-    for (; initer != input_data.end(); ++initer, ++outiter) {
+    for (; initer != input_data.end(); ++initer /* , ++outiter */) {
       // result may be a vector, calculate L2 norm
       const FunctionModel::results_t functionvalue =
@@ -369 +371 @@
   if (!output_data.empty()) {
     filtered_inputs_t::const_iterator initer = input_data.begin();
-    outputs_t::const_iterator outiter = output_data.begin();
+//    outputs_t::const_iterator outiter = output_data.begin();
     size_t index = 0;
-    for (; initer != input_data.end(); ++initer, ++outiter) {
+    for (; initer != input_data.end(); ++initer /*, ++outiter */) {
       // result may be a vector, calculate L2 norm
       for (int paramindex = 0; paramindex < m; ++paramindex) {