Changeset cc9225 for molecuilder/tests/Tesselations/cholesterol

Timestamp:

Nov 24, 2009, 3:34:49 PM (16 years ago)

Author:

Frederik Heber <heber@…>

Children:

1a3354

Parents:

7d1ad9

Message:

Fixes and naming of final Tecplot output file is now molecule name.

• FIXES to builder.cpp:
  • case 'p' would not dissect the molecule into connected subgraphs
  • if done so, the BondGraph was not yet initialised
  • if done so, we need to check whether BondGraphFileName has been set
  • BondGraphFileName.empty() could not be used as a check, as was set to "" instead of "\n"
  • if (finally) done so, we have to remove the empty molecule that we parsed in
  • ... and then pick the newly added molecule for mol to point at
  • SaveConfig() did not set the merged molecule name correctly.
  • if empty config is given, the empty molecule now receives the ConfigFileName as name

• FIXES to config.cpp
  • Load() did not set the name of the molecule

• changes to tesselationhelper.cpp and tesselation.cpp
  • WriteTecplotFile() uses N == -1 to make clear, that we are writing the final not a temporary tecplot file and then uses the molecule's name instead of the last triangle's endpoints
  • FindNextSuitableTriangle(): HasOtherBaselineBetterCandidate() was commented out for the moment (as it is not yet final and makes all the test fail)
  • IncludeSphereinRaster3D() did not check whether LastTriangle was NULL or not

• MoleculeListClass::DissectMoleculeIntoConnectedSubgraphs() names the subgraphs with suffixes "..-1", "..-2", ...

• changes to PointCloud and molecule
  • new virtual function PointCloud::GetName() returns "unknown"
  • new function molecule::GetName() returns pointer to name of molecule
  • IsEmpty() and IsEnd() now return true by default

• all .dat files in the "Tesselations" tests were changed accordingly (i.e. have now the name in the second line)
• benzene was added as a new test for an absolutely flat molecule. So far, it fails horribly.
• 13 of 17 tests run fine

Signed-off-by: Frederik Heber <heber@…>

File:

• molecuilder/tests/Tesselations/cholesterol/NonConvexEnvelope-cholesterol.dat (modified) (1 diff)

molecuilder/tests/Tesselations/cholesterol/NonConvexEnvelope-cholesterol.dat

@@ -1 +1 @@
 TITLE = "3D CONVEX SHELL"
 VARIABLES = "X" "Y" "Z" "U"
-ZONE T="0- H49_ H50_ H51", N=44, E=86, DATAPACKING=POINT, ZONETYPE=FETRIANGLE
+ZONE T="cholesterol", N=44, E=86, DATAPACKING=POINT, ZONETYPE=FETRIANGLE
 19.4519 9.7871 8.0824 1
 12.9054 5.0485 9.284 1