Changeset cb98f1 for src/LinkedCell

Timestamp:

Mar 2, 2017, 2:01:50 PM (8 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_ChronosMutex, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, RotateToPrincipalAxisSystem_UndoRedo, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, Ubuntu_1604_changes, stable

Children:

290c8e

Parents:

dfeb7c

git-author:

Frederik Heber <heber@…> (02/20/17 09:46:50)

git-committer:

Frederik Heber <heber@…> (03/02/17 14:01:50)

Message:

FIX: One Definition Rule violation by mpqc.

• mpqc.cc implements MPQCJob::Work() a second time (other in MPQCJob.cpp), this violates ODR and did so far work out of sheer luck. This was brough to surface by making a debian package.
• Now, we extracted MPQCJob::Work() into a separate library.

File:

• src/LinkedCell/unittests/Makefile.am (modified) (4 diffs)

src/LinkedCell/unittests/Makefile.am

@@ -43 +43 @@
 if CONDJOBMARKET
 linkedcellUnitTest_LDADD += \
-        ../libMolecuilderJobs.la
+        ../libMolecuilderJobs.la \
+        ../libMolecuilderJobs_Work.la
 endif
 linkedcellUnitTest_LDADD += \
@@ -71 +72 @@
 if CONDJOBMARKET
 LinkedCell_ControllerUnitTest_LDADD += \
-        ../libMolecuilderJobs.la
+        ../libMolecuilderJobs.la \
+        ../libMolecuilderJobs_Work.la
 endif
 LinkedCell_ControllerUnitTest_LDADD += \
@@ -85 +87 @@
 if CONDJOBMARKET
 LinkedCell_ModelUnitTest_LDADD += \
-        ../libMolecuilderJobs.la
+        ../libMolecuilderJobs.la \
+        ../libMolecuilderJobs_Work.la
 endif
 LinkedCell_ModelUnitTest_LDADD += \
@@ -100 +103 @@
 if CONDJOBMARKET
 LinkedCell_ViewUnitTest_LDADD += \
-        ../libMolecuilderJobs.la
+        ../libMolecuilderJobs.la \
+        ../libMolecuilderJobs_Work.la
 endif
 LinkedCell_ViewUnitTest_LDADD += \