Changeset c4c113

Timestamp:

Mar 17, 2017, 10:11:35 AM (8 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph_documentation, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_ChronosMutex, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, PartialCharges_OrthogonalSummation, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, RotateToPrincipalAxisSystem_UndoRedo, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, Ubuntu_1604_changes, stable

Children:

eca0d7

Parents:

917c46

git-author:

Frederik Heber <heber@…> (03/17/17 09:47:19)

git-committer:

Frederik Heber <heber@…> (03/17/17 10:11:35)

Message:

FIX: Value_elements was broken from copy&paste.

• inclusion guard was still the one from Value_element.hpp.
• specific typename was still the one from Value_element.hpp.
• TEST: Added CodeCheck test such that specific implementations are always contained in Value.hpp

Files:

• src/Parameters/Specifics/Value_elements.cpp (modified) (1 diff)
• src/Parameters/Specifics/Value_elements.hpp (modified) (3 diffs)
• src/Parameters/Value.hpp (modified) (1 diff)
• tests/CodeChecks/testsuite-specifics_present_in_value_header.at (added)
• tests/CodeChecks/testsuite.at (modified) (1 diff)

src/Parameters/Specifics/Value_elements.cpp

@@ -22 +22 @@
 
 /*
- * Value_elementss.cpp
+ * Value_elements.cpp
  *
  *  Created on: Jul 18, 2015

src/Parameters/Specifics/Value_elements.hpp

@@ -1 +1 @@
 /*
- * Value_element.hpp
+ * Value_elements.hpp
  *
  *  Created on: Sep 10, 2014
@@ -6 +6 @@
  */
 
-#ifndef VALUE_ELEMENT_HPP_
-#define VALUE_ELEMENT_HPP_
+#ifndef VALUE_ELEMENTS_HPP_
+#define VALUE_ELEMENTS_HPP_
 
 // include config.h
@@ -19 +19 @@
 #include "Parameters/Value.hpp"
 
-// This overrides string conversions for the type element which need a specific function call.
+// This overrides string conversions for the type vector<element> which need a specific function call.
 
 template <>
-bool Value<const element *>::isValidAsString(const std::string &_value) const throw(ParameterValidatorException);
+bool Value<std::vector<const element *> >::isValidAsString(const std::string &_value) const throw(ParameterValidatorException);
 
 template <>
-const std::string Value<const element *>::getAsString() const throw(ParameterValueException);
+const std::string Value<std::vector<const element *> >::getAsString() const throw(ParameterValueException);
 
 template <>
-void Value<const element *>::setAsString(const std::string &_value) throw(ParameterException);
+void Value<std::vector<const element *> >::setAsString(const std::string &_value) throw(ParameterException);
 
 
-#endif /* VALUE_ELEMENT_HPP_ */
+#endif /* VALUE_ELEMENTS_HPP_ */

src/Parameters/Value.hpp

@@ -118 +118 @@
 };
 
-#include "Value_impl.hpp"
-
 #include "Specifics/Value_atom.hpp"
 #include "Specifics/Value_element.hpp"
+#include "Specifics/Value_elements.hpp"
 #include "Specifics/Value_molecule.hpp"
 #include "Specifics/Value_string.hpp"
 
+#include "Value_impl.hpp"
+
 #endif /* VALUE_HPP_ */

tests/CodeChecks/testsuite.at

@@ -45 +45 @@
 
 m4_include(testsuite-action_present_in_userguide.at)
+
+m4_include(testsuite-specifics_present_in_value_header.at)