Changeset bb9503 for molecuilder

Timestamp:

Feb 3, 2010, 2:11:10 PM (16 years ago)

Author:

Tillmann Crueger <crueger@…>

Children:

ef4966

Parents:

4272f0

git-author:

Tillmann Crueger <crueger@…> (02/03/10 14:07:23)

git-committer:

Tillmann Crueger <crueger@…> (02/03/10 14:11:10)

Message:

Added mechanism that allows for assign priorities to observers

Location:

molecuilder/src/Patterns

Files:

• Observer.cpp (modified) (6 diffs)
• Observer.hpp (modified) (2 diffs)

molecuilder/src/Patterns/Observer.cpp

@@ -10 +10 @@
 
 #include <iostream>
+#include <cassert>
 
 using namespace std;
@@ -24 +25 @@
 
 map<Observable*, int> Observable::depth;
-multimap<Observable*,Observer*> Observable::callTable;
+map<Observable*,multimap<int,Observer*>*> Observable::callTable;
 set<Observable*> Observable::busyObservables;
 
@@ -54 +55 @@
 /************* Notification mechanism for observables **************/
 
-typedef multimap<Observable*,Observer*>::iterator callIterator;
-typedef pair<callIterator, callIterator> iteratorRange;
 
 void Observable::notifyAll() {
@@ -64 +63 @@
   // and call all observers
   if(callTable.count(this)) {
-     iteratorRange callerRange = callTable.equal_range(this);
-     callIterator iter;
-     for(iter=callerRange.first;iter!=callerRange.second;iter++){
-       (*iter).second->update(this);
-     }
+    // elements are stored sorted by keys in the multimap
+    // so iterating over it gives us a the callees sorted by
+    // the priorities
+    callees_t *callees = callTable[this];
+    callees_t::iterator iter;
+    for(iter=callees->begin();iter!=callees->end();iter++){
+      (*iter).second->update(this);
+    }
   }
   // done with notification, we can leave the set of busy subjects
@@ -97 +99 @@
 
 // methods to sign-on and off
-void Observable::signOn(Observer *target) {
+void Observable::signOn(Observer *target,int priority) {
+  assert(priority>=-20 && priority<=+20 && "Priority out of range [-20:+20]");
   bool res = false;
-  iteratorRange callerRange = callTable.equal_range(this);
-  callIterator iter;
-  for(iter=callerRange.first;iter!=callerRange.second;iter++){
+  callees_t *callees = 0;
+  if(callTable.count(this)){
+    callees = callTable[this];
+  }
+  else {
+    callees = new multimap<int,Observer*>;
+    callTable.insert(pair<Observable*,callees_t*>(this,callees));
+  }
+
+  callees_t::iterator iter;
+  for(iter=callees->begin();iter!=callees->end();iter++){
     res |= ((*iter).second == target);
   }
   if(!res)
-    callTable.insert(pair<Observable*,Observer*>(this,target));
+    callees->insert(pair<int,Observer*>(priority,target));
 }
 
 void Observable::signOff(Observer *target) {
-  iteratorRange callerRange = callTable.equal_range(this);
-  callIterator iter;
-  for(iter=callerRange.first;iter!=callerRange.second;iter++) {
+  assert(callTable.count(this) && "SignOff called for an Observable without Observers.");
+  callees_t *callees = callTable[this];
+  callees_t::iterator iter;
+  for(iter=callees->begin();iter!=callees->end();iter++) {
     if((*iter).second == target)
-      callTable.erase(iter);
+      callees->erase(iter);
+  }
+  if(callees->empty()){
+    callTable.erase(this);
+    delete callees;
   }
 }
@@ -127 +143 @@
 Observable::~Observable()
 {
-  // delete all entries for this observable
-  iteratorRange callerRange = callTable.equal_range(this);
-  callIterator iter;
-  for(iter=callerRange.first;iter!=callerRange.second;iter++){
-    (*iter).second->subjectKilled(this);
+  if(callTable.count(this)) {
+    // delete all entries for this observable
+    callees_t *callees = callTable[this];
+    callees_t::iterator iter;
+    for(iter=callees->begin();iter!=callees->end();iter++){
+      (*iter).second->subjectKilled(this);
+    }
+    callTable.erase(this);
+    delete callees;
   }
-  callTable.erase(callerRange.first,callerRange.second);
 }
 

molecuilder/src/Patterns/Observer.hpp

@@ -50 +50 @@
   virtual ~Observable();
 
-  virtual void signOn(Observer *target);
+  virtual void signOn(Observer *target, int priority=0);
   virtual void signOff(Observer *target);
 
@@ -72 +72 @@
 
 private:
+  typedef std::multimap<int,Observer*> callees_t;
   static std::map<Observable*, int> depth;
-  static std::multimap<Observable*,Observer*> callTable;
+  static std::map<Observable*,callees_t*> callTable;
   static std::set<Observable*> busyObservables;
 };