Changeset b11f5e

Timestamp:

Feb 13, 2013, 3:47:46 PM (12 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

6440c6

Parents:

9e6722

git-author:

Frederik Heber <heber@…> (01/09/13 20:46:04)

git-committer:

Frederik Heber <heber@…> (02/13/13 15:47:46)

Message:

FIX: Value::setAsString(), ::getAsString take const ref.

• arg chain was string instances before, corrected to const ref.
• also extracted Value<bool> specialization into own module.

Location:

src

Files:

• Parameters/Parameter.hpp (modified) (1 diff)
• Parameters/Parameter_impl.hpp (modified) (1 diff)
• Parameters/Value.hpp (modified) (2 diffs)
• Parameters/ValueAsString.hpp (modified) (1 diff)
• Parameters/Value_impl.hpp (modified) (2 diffs)
• Parameters/Value_string.cpp (modified) (2 diffs)
• Parameters/Value_string.hpp (modified) (1 diff)
• Parser/MpqcParser_Parameters.hpp (modified) (1 diff)

src/Parameters/Parameter.hpp

@@ -46 +46 @@
   const T & get() const throw(ParameterValueException);
   void set(const T & _value) throw(ParameterValueException);
-  void setAsString(const std::string _value) throw(ParameterValueException);
+  void setAsString(const std::string &_value) throw(ParameterValueException);
 
   // comparator

src/Parameters/Parameter_impl.hpp

@@ -189 +189 @@
  */
 template<typename T>
-inline void Parameter<T>::setAsString(const std::string _value) throw(ParameterValueException)
+inline void Parameter<T>::setAsString(const std::string &_value) throw(ParameterValueException)
 {
   try {

src/Parameters/Value.hpp

@@ -40 +40 @@
 template <class T>
 struct ConvertTo< std::vector<T> > {
-  std::vector<T> operator()(std::string _object) {
+  std::vector<T> operator()(const std::string &_object) {
     std::vector<T> returnobjects;
     std::stringstream s;
@@ -77 +77 @@
 
   // string functions for ValueInterface
-  bool isValidAsString(const std::string _value) const throw(ParameterValidatorException);
+  bool isValidAsString(const std::string &_value) const throw(ParameterValidatorException);
   const std::string getAsString() const throw(ParameterValueException);
-  void setAsString(const std::string _value) throw(ParameterException);
+  void setAsString(const std::string &_value) throw(ParameterException);
 
   // comfortable setter

src/Parameters/ValueAsString.hpp

@@ -26 +26 @@
 
   // string functions
-  virtual bool isValidAsString(const std::string _value) const=0;
+  virtual bool isValidAsString(const std::string &_value) const=0;
   virtual const std::string getAsString() const=0;
-  virtual void setAsString(const std::string _value)=0;
+  virtual void setAsString(const std::string &_value)=0;
 };
 

src/Parameters/Value_impl.hpp

@@ -154 +154 @@
  */
 template <class T>
-inline bool Value<T>::isValidAsString(const std::string _value) const throw(ParameterValidatorException)
+inline bool Value<T>::isValidAsString(const std::string &_value) const throw(ParameterValidatorException)
 {
   const T castvalue = Converter(_value);
@@ -177 +177 @@
  */
 template <class T>
-inline void Value<T>::setAsString(const std::string _value) throw(ParameterException)
+inline void Value<T>::setAsString(const std::string &_value) throw(ParameterException)
 {
   const T castvalue = Converter(_value);

src/Parameters/Value_string.cpp

@@ -38 +38 @@
 
 template <>
-bool Value<std::string>::isValidAsString(const std::string _value) const throw(ParameterValidatorException)
+bool Value<std::string>::isValidAsString(const std::string &_value) const throw(ParameterValidatorException)
 {
   return isValid(_value);
@@ -44 +44 @@
 
 template <>
-void Value<std::string>::setAsString(const std::string _value) throw(ParameterException)
+void Value<std::string>::setAsString(const std::string &_value) throw(ParameterException)
 {
   set(_value);

src/Parameters/Value_string.hpp

@@ -19 +19 @@
 
 template <>
-bool Value<std::string>::isValidAsString(const std::string _value) const throw(ParameterValidatorException);
+bool Value<std::string>::isValidAsString(const std::string &_value) const throw(ParameterValidatorException);
 
 template <>
-void Value<std::string>::setAsString(const std::string _value) throw(ParameterException);
+void Value<std::string>::setAsString(const std::string &_value) throw(ParameterException);
 
 #endif /* VALUE_STRING_HPP_ */

src/Parser/MpqcParser_Parameters.hpp

@@ -21 +21 @@
 
 #include "Parser/FormatParser_Parameters.hpp"
-
 
 class MpqcParser;