Changeset 917c46 for src/UIElements

Timestamp:

Mar 17, 2017, 10:11:35 AM (8 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, AutomationFragmentation_failures, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph_documentation, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_ChronosMutex, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids_IntegrationTest, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, PartialCharges_OrthogonalSummation, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, RotateToPrincipalAxisSystem_UndoRedo, StoppableMakroAction, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, Ubuntu_1604_changes, stable

Children:

c4c113

Parents:

d50b91

git-author:

Frederik Heber <heber@…> (03/17/17 07:20:07)

git-committer:

Frederik Heber <heber@…> (03/17/17 10:11:35)

Message:

FIX: Gui tests would not abort if an intermediate action failed.

• as we step line by line through the test script, if an action sandwhiched between others fails, then the following ones still get executed, overriding the non-zero exit flag.
• now, we check whether the last action failed and break.

File:

• src/UIElements/Qt4/QtUIFactory.cpp (modified) (1 diff)

src/UIElements/Qt4/QtUIFactory.cpp

@@ -168 +168 @@
           testlauncher_sleep(boost::posix_time::seconds(.1));
         } while (!MoleCuilder::ActionQueue::getInstance().isIdle());
+        // check whether last action did not fail (otherwise we would reset
+        // the ActionQueue's exitflag by adding more Actions.
+        if (!MoleCuilder::ActionQueue::getInstance().getLastActionOk()) {
+          std::cout << "Last Action has failed, aborting testrun." << std::endl;
+          break;
+        }
       }
     } else {