Changeset 89a67f for src

Timestamp:

Oct 17, 2011, 4:56:31 PM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

ee50c1

Parents:

c0da07

git-author:

Frederik Heber <heber@…> (09/30/11 16:19:34)

git-committer:

Frederik Heber <heber@…> (10/17/11 16:56:31)

Message:

Added StringParameter as ContinuousParameter<string> as string do not have any sensible valid range.

• this does not inherit any StringValue but implements ValueInterface right away.
• also added unit test.

Location:

src/Parser/Parameters

Files:

• StringParameter.cpp (added)
• StringParameter.hpp (added)
• unittests/Makefile.am (modified) (4 diffs)
• unittests/StringParameterUnitTest.cpp (added)
• unittests/StringParameterUnitTest.hpp (added)

src/Parser/Parameters/unittests/Makefile.am

@@ -8 +8 @@
         ../Parser/Parameters/unittests/DiscreteValueUnitTest.cpp \
         ../Parser/Parameters/unittests/DiscreteParameterUnitTest.cpp \
-        ../Parser/Parameters/unittests/ParameterStorageUnitTest.cpp
+        ../Parser/Parameters/unittests/ParameterStorageUnitTest.cpp \
+        ../Parser/Parameters/unittests/StringParameterUnitTest.cpp
 
 PARSERPARAMETERSTESTSHEADERS = \
@@ -15 +16 @@
         ../Parser/Parameters/unittests/DiscreteValueUnitTest.hpp \
         ../Parser/Parameters/unittests/DiscreteParameterUnitTest.hpp \
-        ../Parser/Parameters/unittests/ParameterStorageUnitTest.hpp
+        ../Parser/Parameters/unittests/ParameterStorageUnitTest.hpp \
+        ../Parser/Parameters/unittests/StringParameterUnitTest.hpp
 
 PARSERPARAMETERSTESTS = \
@@ -22 +24 @@
         DiscreteValueUnitTest \
         DiscreteParameterUnitTest \
-        ParameterStorageUnitTest
+        ParameterStorageUnitTest \
+        StringParameterUnitTest
 
 TESTS += $(PARSERPARAMETERSTESTS)
@@ -86 +89 @@
         $(CodePatterns_LIBS) \
         $(PARSERPARAMETERSLIBS)
+
+StringParameterUnitTest_SOURCES = $(top_srcdir)/src/unittests/UnitTestMain.cpp \
+        ../Parser/Parameters/unittests/StringParameterUnitTest.cpp \
+        ../Parser/Parameters/unittests/StringParameterUnitTest.hpp \
+        ../Parser/Parameters/StringParameter.cpp \
+        ../Parser/Parameters/StringParameter.hpp \
+        ../Parser/Parameters/Parameter.hpp \
+        ../Parser/Parameters/ValueInterface.hpp
+StringParameterUnitTest_LDADD = \
+        $(PARSERPARAMETERSLIBS)
+ 
  
 #AUTOMAKE_OPTIONS = parallel-tests