Changeset 8281cc for src/UIElements

Timestamp:

Feb 14, 2016, 12:34:29 PM (9 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

03e69e

Parents:

1c0961

git-author:

Frederik Heber <heber@…> (01/07/16 12:00:38)

git-committer:

Frederik Heber <heber@…> (02/14/16 12:34:29)

Message:

FIX: Making sure that atomInserted is received from same source in GLWorldScene and GLMoleculeObject_molecule.

• otherwise we cannot guarantee that the events are processed in order.

Location:

src/UIElements/Views/Qt4/Qt3D

Files:

• GLWorldScene.cpp (modified) (7 diffs)
• GLWorldScene.hpp (modified) (5 diffs)

src/UIElements/Views/Qt4/Qt3D/GLWorldScene.cpp

@@ -94 +94 @@
   }
   connect(board, SIGNAL(moleculeInserted(QtObservedMolecule::ptr)),
-      this, SLOT(moleculeInserted(QtObservedMolecule::ptr)));
+      this, SLOT(moleculeSignOn(QtObservedMolecule::ptr)));
   connect(board, SIGNAL(moleculeRemoved(const moleculeId_t)),
-      this, SLOT(moleculeRemoved(const moleculeId_t)));
+      this, SLOT(moleculeSignOff(const moleculeId_t)));
   connect(board, SIGNAL(moleculeIndexChanged(const moleculeId_t, const moleculeId_t)),
       this, SLOT(moleculeIndexChanged(const moleculeId_t, const moleculeId_t)));
-  connect(board, SIGNAL(atomInserted(QtObservedAtom::ptr)),
-      this, SLOT(atomInserted(QtObservedAtom::ptr)));
-  connect(board, SIGNAL(atomRemoved(const moleculeId_t, const atomId_t)),
-      this, SLOT(atomRemoved(const moleculeId_t, const atomId_t)));
+  connect(this, SIGNAL(insertMolecule(QtObservedMolecule::ptr)),
+      this, SLOT(moleculeInserted(QtObservedMolecule::ptr)) );
+  connect(this, SIGNAL(removeMolecule(const moleculeId_t)),
+      this, SLOT(moleculeRemoved(const moleculeId_t)) );
 
 //  connect(this, SIGNAL(updated()), this, SLOT(update()));
@@ -174 +174 @@
     MoleculeMissedStateMap[molid].insert( std::make_pair(atomid, atomInsertedState) );
     QtObservedAtomMap[atomid] = _atom;
+    connect(_atom.get(), SIGNAL(indexChanged(const atomId_t,const atomId_t)),
+        this, SLOT(atomIndexChanged(const atomId_t,const atomId_t)) );
     LOG(3, "INFO: GLWorldScene: Placing atomInserted for atom " << atomid
          << " and molecule " << molid << " into missed state map.");
@@ -184 +186 @@
  * @param _atomid atom to insert
  */
-void GLWorldScene::atomRemoved(const moleculeId_t _molid, const atomId_t _atomid)
-{
+void GLWorldScene::atomRemoved(const atomId_t _atomid)
+{
+  boost::recursive_mutex::scoped_lock lock(MoleculeMissedStateMap_mutex);
+
   LOG(3, "INFO: GLWorldScene: Received signal atomRemoved for atom "+toString(_atomid)+".");
 
-  boost::recursive_mutex::scoped_lock lock(MoleculeMissedStateMap_mutex);
-
-  // check of molecule is already present
-  MoleculeNodeMap::iterator moliter = MoleculesinSceneMap.find(_molid);
-  if (moliter != MoleculesinSceneMap.end()) {
-    // no action, is also caught via QtObservedMolecule by GLMoleculeObject_molecule
-  } else {
-    // store signal for when it is instantiated
-    if (MoleculeMissedStateMap.count(_molid) == 0)
-      MoleculeMissedStateMap.insert( std::make_pair(_molid ,StateChangeMap_t()) );
-    MoleculeMissedStateMap[_molid].insert( std::make_pair(_atomid, atomRemovedState) );
-    LOG(3, "INFO: GLWorldScene: Placing atomRemoved for atom " << _atomid
-         << " and molecule " << _molid << " into missed state map.");
-  }
+  // if atom is not in map, then GLMoleculeObject_molecule is already present anyway.
+  if (QtObservedAtomMap.count(_atomid)) {
+    const QtObservedAtom::ptr atom = QtObservedAtomMap[_atomid];
+    const moleculeId_t molid = atom->getAtomMoleculeIndex();
+    // check of molecule is already present
+    MoleculeNodeMap::iterator moliter = MoleculesinSceneMap.find(molid);
+    if (moliter != MoleculesinSceneMap.end()) {
+      // no action, is also caught via QtObservedMolecule by GLMoleculeObject_molecule
+    } else {
+      // store signal for when it is instantiated
+      if (MoleculeMissedStateMap.count(molid) == 0)
+        MoleculeMissedStateMap.insert( std::make_pair(molid ,StateChangeMap_t()) );
+      MoleculeMissedStateMap[molid].insert( std::make_pair(_atomid, atomRemovedState) );
+      LOG(3, "INFO: GLWorldScene: Placing atomRemoved for atom " << _atomid
+           << " and molecule " << molid << " into missed state map.");
+    }
+  }
+}
+
+void GLWorldScene::moleculeSignOn(QtObservedMolecule::ptr _mol)
+{
+  // sign on to QtObservedMolecule to get atomInserted/..Removed signals from same
+  // source as GLMoleculeObject_molecule would
+  connect(_mol.get(), SIGNAL(atomInserted(QtObservedAtom::ptr)),
+      this, SLOT(atomInserted(QtObservedAtom::ptr)) );
+  connect(_mol.get(), SIGNAL(atomRemoved(const atomId_t)),
+      this, SLOT(atomRemoved(const atomId_t)) );
+  const moleculeId_t molid = _mol->getMolIndex();
+  QtObservedMoleculeMap.insert( std::make_pair(molid, _mol) );
+
+  LOG(3, "INFO: GLWorldScene: Received signal moleculeSignOn for molecule "+toString(molid)+".");
+
+  emit insertMolecule(_mol);
+}
+
+void GLWorldScene::moleculeSignOff(const moleculeId_t _id)
+{
+  ASSERT( QtObservedMoleculeMap.count(_id),
+      "GLWorldScene::moleculeSignOff() - cannot find id "+toString(_id)+" in map.");
+  const QtObservedMolecule::ptr mol = QtObservedMoleculeMap[_id];
+  mol->disconnect(this);
+  QtObservedMoleculeMap.erase(_id);
+
+  LOG(3, "INFO: GLWorldScene: Received signal moleculeSignOff for molecule "+toString(_id)+".");
+
+  emit removeMolecule(_id);
 }
 
@@ -289 +325 @@
           {
             LOG(1, "INFO: invoking atomInserted for atom " << iter->first);
+            const QtObservedAtom::ptr walker = QtObservedAtomMap[iter->first];
             QMetaObject::invokeMethod(molObject,        // pointer to a QObject
                                       "atomInserted",       // member name (no parameters here)
@@ -357 +394 @@
 }
 
+void GLWorldScene::atomIndexChanged(const atomId_t _oldid, const atomId_t _newid)
+{
+  if (QtObservedAtomMap.count(_oldid)) {
+    const QtObservedAtom::ptr atom = QtObservedAtomMap[_oldid];
+    QtObservedAtomMap.erase(_oldid);
+    QtObservedAtomMap.insert( std::make_pair(_newid, atom) );
+  }
+}
+
 void GLWorldScene::moleculeIndexChanged(const moleculeId_t _oldid, const moleculeId_t _newid)
 {
@@ -367 +413 @@
     RemovalMolecules.erase(removeiter);
     RemovalMolecules.insert(_newid);
+    if (QtObservedMoleculeMap.count(_oldid)) {
+      const QtObservedMolecule::ptr mol = QtObservedMoleculeMap[_oldid];
+      QtObservedMoleculeMap.erase(_oldid);
+      QtObservedMoleculeMap.insert( std::make_pair(_newid, mol) );
+    }
   } else {
     LOG(1, "DEBUG: Changing GLMoleculeObject_molecule from " << _oldid << " to id " << _newid);
@@ -467 +518 @@
 }
 
-void GLWorldScene::changeMoleculeId(
-    GLMoleculeObject_molecule *ob,
-    const moleculeId_t oldId,
-    const moleculeId_t newId)
-{
-  LOG(3, "INFO: GLWorldScene - change molecule id " << oldId << " to " << newId << ".");
-
-  {
-    boost::recursive_mutex::scoped_lock lock(MoleculeinSceneMap_mutex);
-    // Remove from map.
-    MoleculeNodeMap::iterator iter = MoleculesinSceneMap.find(oldId);
-    ASSERT(iter != MoleculesinSceneMap.end(),
-        "GLWorldScene::changeMoleculeId() - molecule with old id "+toString(oldId)+" not on display.");
-    ASSERT(iter->second == ob,
-        "GLWorldScene::changeMoleculeId() - molecule with id "
-        +toString(oldId)+" does not match with object in MoleculesinSceneMap.");
-    MoleculesinSceneMap.erase(iter);
-
-    // Reinsert with new id.
-    {
-      MoleculeNodeMap::iterator iter = MoleculesinSceneMap.find(newId);
-      ASSERT(iter == MoleculesinSceneMap.end(),
-            "GLWorldScene::changeMoleculeId() -  moleculewith new id "+toString(newId)+" already known.");
-    }
-    MoleculesinSceneMap.insert( make_pair(newId, ob) );
-  }
-
-  {
-    boost::recursive_mutex::scoped_lock lock(MoleculeMissedStateMap_mutex);
-    // Remove and re-insert from map if present.
-    MoleculeMissedStateMap_t::iterator iter = MoleculeMissedStateMap.find(oldId);
-    if (iter != MoleculeMissedStateMap.end()) {
-      StateChangeMap_t changemap = iter->second;
-      MoleculeMissedStateMap.erase(iter);
-      MoleculeMissedStateMap.insert( std::make_pair(newId, changemap) );
-    }
-  }
-}
-

src/UIElements/Views/Qt4/Qt3D/GLWorldScene.hpp

@@ -84 +84 @@
   void hoverChanged(const atomId_t);
   void hoverChanged(const moleculeId_t, int);
+  void insertMolecule(QtObservedMolecule::ptr);
+  void removeMolecule(const moleculeId_t);
 
 private slots:
@@ -89 +91 @@
   void moleculeClicked(moleculeId_t no);
   void moleculeRemoved(const moleculeId_t _id);
+  void moleculeSignOff(const moleculeId_t _id);
   void moleculeInserted(QtObservedMolecule::ptr);
+  void moleculeSignOn(QtObservedMolecule::ptr);
   void moleculeIndexChanged(const moleculeId_t _oldid, const moleculeId_t _newid);
-  void atomRemoved(const moleculeId_t _molid, const atomId_t _atomid);
+  void atomRemoved(const atomId_t _atomid);
   void atomInserted(QtObservedAtom::ptr);
+  void atomIndexChanged(const atomId_t _oldid, const atomId_t _newid);
   void setSelectionModeAtom();
   void setSelectionModeMolecule();
@@ -99 +104 @@
 //  void update();
   void moleculesVisibilityChanged(const moleculeId_t _id, bool _visible);
-  void changeMoleculeId(GLMoleculeObject_molecule *, const moleculeId_t, const moleculeId_t);
 
 public:
@@ -124 +128 @@
   };
   typedef std::map< atomId_t, QtObservedAtom::ptr> QtObservedAtomMap_t;
+  typedef std::map< moleculeId_t, QtObservedMolecule::ptr> QtObservedMoleculeMap_t;
   typedef std::multimap< atomId_t, StateChangeType> StateChangeMap_t;
   typedef std::map< moleculeId_t, StateChangeMap_t> MoleculeMissedStateMap_t;
@@ -130 +135 @@
   //!> map to contain all QtObservedAtom that have not been instantiated so far
   QtObservedAtomMap_t QtObservedAtomMap;
+  //!> map to contain all QtObservedMolecule that have not been instantiated so far
+  QtObservedMoleculeMap_t QtObservedMoleculeMap;
   //!> flag to indicate whether state map is currently worked on
   boost::recursive_mutex MoleculeMissedStateMap_mutex;