Changeset 70caa3

Timestamp:

Jun 20, 2018, 8:20:43 AM (7 years ago)

Author:

Frederik Heber <frederik.heber@…>

Branches:

AutomationFragmentation_failures, Candidate_v1.6.1, ChemicalSpaceEvaluator, Exclude_Hydrogens_annealWithBondGraph, ForceAnnealing_with_BondGraph_contraction-expansion, StoppableMakroAction

Children:

883d98, a6c11a

Parents:

4b2adf

git-author:

Frederik Heber <frederik.heber@…> (09/15/17 08:21:12)

git-committer:

Frederik Heber <frederik.heber@…> (06/20/18 08:20:43)

Message:

FIX: FormatParserStorage would open new streams per SaveAll().

• we did not check whether an open stream was still present and always opened a new one: OutputAction would cause an "too many open files" at some point because all those streams (on the same filename) were never closed.

File:

• src/Parser/FormatParserStorage.cpp (modified) (2 diffs)

src/Parser/FormatParserStorage.cpp

@@ -201 +201 @@
 {
   std::string filename;
-  for (ParserTypes iter = ParserTypes_begin; iter < ParserTypes_end; ++iter)
+  for (ParserTypes iter = ParserTypes_begin; iter < ParserTypes_end; ++iter) {
+    // open a new stream, if parser is desired. Reopen such stream if already present
     if (ParserPresent[iter] && ParserDesiredOutputFormat[iter]) {
+      if (ParserStream[iter] != NULL) {
+        if (ParserStream[iter]->is_open()) {
+          ParserStream[iter]->flush();
+          ParserStream[iter]->close();
+        }
+        delete ParserStream[iter];
+        ParserStream[iter] = NULL;
+        ParserList[iter]->setOstream(ParserStream[iter]);
+      }
       filename = prefix;
       filename += ".";
@@ -209 +219 @@
       ParserList[iter]->setOstream((std::ostream *)ParserStream[iter]);
     }
+  }
 }