Changeset 6d574a for src

Timestamp:

Jun 24, 2010, 2:31:45 PM (15 years ago)

Author:

Tillmann Crueger <crueger@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

0d1ad0

Parents:

906822

Message:

Replaced several old-style asserts with more usable ASSERTs

Location:

src

Files:

• Descriptors/AtomDescriptor.cpp (modified) (1 diff)
• Descriptors/MoleculeDescriptor.cpp (modified) (1 diff)
• Helpers/MemDebug.cpp (modified) (1 diff)
• Patterns/Singleton.hpp (modified) (3 diffs)
• Patterns/Singleton_impl.hpp (modified) (2 diffs)
• UIElements/Dialog.cpp (modified) (1 diff)
• World.cpp (modified) (5 diffs)
• tesselation.cpp (modified) (3 diffs)
• unittests/Makefile.am (modified) (1 diff)
• unittests/manipulateAtomsTest.cpp (modified) (3 diffs)

src/Descriptors/AtomDescriptor.cpp

@@ -12 +12 @@
 
 #include "World.hpp"
-
 #include "atom.hpp"
 
 #include <boost/bind.hpp>
-#include <cassert>
+
 #include <iostream>
 

src/Descriptors/MoleculeDescriptor.cpp

@@ -16 +16 @@
 
 #include <boost/bind.hpp>
-#include <cassert>
 #include <iostream>
 

src/Helpers/MemDebug.cpp

@@ -6 +6 @@
  */
 
-#ifndef NDBEGUG
+#ifndef NDEBUG
 #ifndef NO_MEMDEBUG
 

src/Patterns/Singleton.hpp

@@ -9 +9 @@
 #define SINGLETON_HPP_
 
-#include <cassert>
 #include <boost/thread.hpp>
 
+#include "Helpers/Assert.hpp"
 #include "defs.hpp"
 
@@ -181 +181 @@
 
     inline static void set(creator_T*&,creator_T*){
-      assert(0 && "Cannot set the Instance for a singleton of this type");
+      ASSERT(0, "Cannot set the Instance for a singleton of this type");
     }
   };
@@ -191 +191 @@
   struct creator_t<creator_T,false>{
     inline static creator_T* make(){
-      assert(0 && "Cannot create a singleton of this type directly");
+      ASSERT(0, "Cannot create a singleton of this type directly");
+      return 0;
     }
     inline static void set(ptr_t& dest,creator_T* src){

src/Patterns/Singleton_impl.hpp

@@ -72 +72 @@
 template <class T,bool _may_create>
 void Singleton<T,_may_create>::setInstance(T* newInstance){
-  assert(!theInstance.get() && "Trying to set the instance of an already created singleton");
+  ASSERT(!theInstance.get(), "Trying to set the instance of an already created singleton");
   boost::recursive_mutex::scoped_lock guard(instanceLock);
   theInstance.reset(newInstance);
@@ -83 +83 @@
 template <class T, bool _may_create>
 Singleton<T,_may_create>::Singleton(const Singleton<T,_may_create>&){
-  assert(0 && "Copy constructor of singleton template called");
+  ASSERT(0, "Copy constructor of singleton template called");
 }
 

src/UIElements/Dialog.cpp

@@ -7 +7 @@
 
 #include "Helpers/MemDebug.hpp"
-
-#include <cassert>
 
 #include "Dialog.hpp"

src/World.cpp

@@ -20 +20 @@
 #include "Descriptors/SelectiveIterator_impl.hpp"
 #include "Actions/ManipulateAtomsProcess.hpp"
+#include "Helpers/Assert.hpp"
 
 #include "Patterns/Singleton_impl.hpp"
@@ -105 +106 @@
   molecule *mol = NULL;
   mol = NewMolecule();
-  assert(!molecules.count(currMoleculeId));
+  ASSERT(!molecules.count(currMoleculeId),"currMoleculeId did not specify an unused ID");
   mol->setId(currMoleculeId++);
   // store the molecule by ID
@@ -121 +122 @@
   OBSERVE;
   molecule *mol = molecules[id];
-  assert(mol);
+  ASSERT(mol,"Molecule id that was meant to be destroyed did not exist");
   DeleteMolecule(mol);
   molecules.erase(id);
@@ -157 +158 @@
   OBSERVE;
   atom *atom = atoms[id];
-  assert(atom);
+  ASSERT(atom,"Atom ID that was meant to be destroyed did not exist");
   DeleteAtom(atom);
   atoms.erase(id);
@@ -169 +170 @@
   if(!target){
     target = atoms[oldId];
-    assert(target && "Atom with that ID not found");
+    ASSERT(target,"Atom with that ID not found");
     return target->changeId(newId);
   }

src/tesselation.cpp

@@ -9 +9 @@
 
 #include <fstream>
-#include <assert.h>
 
 #include "helpers.hpp"
@@ -24 +23 @@
 #include "Plane.hpp"
 #include "Exceptions/LinearDependenceException.hpp"
-#include "Helpers/Assert.hpp"
-
 #include "Helpers/Assert.hpp"
 
@@ -2527 +2524 @@
     baseline = Runner->second;
     if (baseline->pointlist.empty()) {
-      assert((baseline->BaseLine->triangles.size() == 1) && ("Open line without exactly one attached triangle"));
+      ASSERT((baseline->BaseLine->triangles.size() == 1),"Open line without exactly one attached triangle");
       T = (((baseline->BaseLine->triangles.begin()))->second);
       DoLog(1) && (Log() << Verbose(1) << "Finding best candidate for open line " << *baseline->BaseLine << " of triangle " << *T << endl);

src/unittests/Makefile.am

@@ -210 +210 @@
 
 SingletonTest_SOURCES = UnitTestMain.cpp SingletonTest.cpp SingletonTest.hpp
-SingletonTest_LDADD = $(BOOST_LIB) ${BOOST_THREAD_LIB}
+SingletonTest_LDADD = ${ALLLIBS} $(BOOST_LIB) ${BOOST_THREAD_LIB}
 
 StackClassUnitTest_SOURCES = UnitTestMain.cpp stackclassunittest.cpp stackclassunittest.hpp

src/unittests/manipulateAtomsTest.cpp

@@ -87 +87 @@
 static void operation(atom* _atom){
   AtomStub *atom = dynamic_cast<AtomStub*>(_atom);
-  assert(atom);
+  CPPUNIT_ASSERT(atom);
   atom->doSomething();
 }
@@ -100 +100 @@
     AtomStub *atom;
     atom = dynamic_cast<AtomStub*>(*iter);
-    assert(atom);
+    CPPUNIT_ASSERT(atom);
     CPPUNIT_ASSERT(atom->manipulated);
   }
@@ -114 +114 @@
     AtomStub *atom;
     atom = dynamic_cast<AtomStub*>(*iter);
-    assert(atom);
+    CPPUNIT_ASSERT(atom);
     if(atom->getId()!=(int)ATOM_COUNT/2)
       CPPUNIT_ASSERT(atom->manipulated);