Changeset 647148 for src/Actions

Timestamp:

Sep 9, 2016, 8:22:09 AM (8 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_StructOpt_integration_tests, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, GeometryObjects, Gui_displays_atomic_force_velocity, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, Ubuntu_1604_changes, stable

Children:

d33f24

Parents:

27e6a7

git-author:

Frederik Heber <heber@…> (09/01/16 14:11:53)

git-committer:

Frederik Heber <heber@…> (09/09/16 08:22:09)

Message:

FIX: HomologyGraph's getNodeFromSet() and getEdgesFromSet ignored saturation hydrogens.

• we need to add hydrogen bonds times bond degree for every non-member encountered in the bond list in both edges and hydrogens. Otherwise, we get HomologyGraphs such as "[Z6,E0]" instead of "4x[Z1,E1], 1x[Z6,E4]" for a CH4 fragment.
• this came up when we tried to fit a CH morse potential for the larger bio molecule 1KDF.

File:

• src/Actions/FragmentationAction/AnalyseFragmentationResultsAction.cpp (modified) (1 diff)

src/Actions/FragmentationAction/AnalyseFragmentationResultsAction.cpp

@@ -306 +306 @@
   const IndexSetContainer::Container_t &Indices = shortrangeresults.getContainer();
   const IndexSetContainer::Container_t &ForceIndices = ForceContainer->getContainer();
+  ASSERT( Indices.size() == ForceIndices.size(),
+      "appendToHomologies() - Indices ("+toString(Indices.size())
+      +") and ForceIndices ("+toString(ForceIndices.size())+") sizes differ.");
   IndexSetContainer::Container_t::const_iterator iter = Indices.begin();
   IndexSetContainer::Container_t::const_iterator forceiter = ForceIndices.begin();