Changeset 5e2864 for src/LinkedCell

Timestamp:

Feb 22, 2012, 11:28:52 AM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

ce81e76

Parents:

429069

git-author:

Frederik Heber <heber@…> (01/05/12 18:27:59)

git-committer:

Frederik Heber <heber@…> (02/22/12 11:28:52)

Message:

FIX: LinkedCell_Controller now signs on to Channel Box::MatrixChanged.

• before we just had this in the test but not in _Controller's cstor.

Location:

src/LinkedCell

Files:

• LinkedCell_Controller.cpp (modified) (2 diffs)
• unittests/LinkedCell_ControllerUnitTest.cpp (modified) (2 diffs)

src/LinkedCell/LinkedCell_Controller.cpp

@@ -46 +46 @@
     domain(_domain)
 {
+  // sign on to specific notifications
+  domain.signOn(this, Box::MatrixChanged);
+
   /// Check that upper_threshold fits within half the box.
   Vector diagonal(1.,1.,1.);
@@ -68 +71 @@
 LinkedCell_Controller::~LinkedCell_Controller()
 {
+  // sign off
+  domain.signOff(this, Box::MatrixChanged);
+
   /// we free all LinkedCell_Model instances again.
   for(MapEdgelengthModel::iterator iter = ModelsMap.begin();

src/LinkedCell/unittests/LinkedCell_ControllerUnitTest.cpp

@@ -263 +263 @@
 void LinkedCell_ControllerTest::updateBoxTest()
 {
-  /// sign on to domain
-  domain->signOn(controller, Box::MatrixChanged);
-
   /// obtain a view
   const double edgelength = controller->upper_threshold;
@@ -278 +275 @@
   /// check that model has changed
   CPPUNIT_ASSERT( model != view.LC->getModel() );
-
-  /// sign off
-  domain->signOff(controller, Box::MatrixChanged);
-}
+}