Changes in src/unittests/PlaneUnittest.cpp [407782:3dcb1f]

File:

• src/unittests/PlaneUnittest.cpp (modified) (6 diffs)

src/unittests/PlaneUnittest.cpp

@@ -24 +24 @@
 
 void PlaneUnittest::setUp(){
-  p1 = new Plane(unitVec[0],unitVec[1],unitVec[2]);
-  p2 = new Plane(unitVec[0],unitVec[1],zeroVec);
-  p3 = new Plane(unitVec[0],zeroVec,unitVec[2]);
-  p4 = new Plane(zeroVec,unitVec[1],unitVec[2]);
+  p1 = new Plane(e1,e2,e3);
+  p2 = new Plane(e1,e2,zeroVec);
+  p3 = new Plane(e1,zeroVec,e3);
+  p4 = new Plane(zeroVec,e2,e3);
 }
 
@@ -42 +42 @@
 
   // three points
-  CPPUNIT_ASSERT_NO_THROW(Plane(unitVec[0],unitVec[1],unitVec[2]));
+  CPPUNIT_ASSERT_NO_THROW(Plane(e1,e2,e3));
   // when only two points are differnt this gives an error
-  CPPUNIT_ASSERT_THROW(Plane(unitVec[0],unitVec[1],unitVec[1]),LinearDependenceException);
+  CPPUNIT_ASSERT_THROW(Plane(e1,e2,e2),LinearDependenceException);
   // same with only one point
-  CPPUNIT_ASSERT_THROW(Plane(unitVec[0],unitVec[0],unitVec[0]),LinearDependenceException);
+  CPPUNIT_ASSERT_THROW(Plane(e1,e1,e1),LinearDependenceException);
 
   // use two vector giving two directions
-  CPPUNIT_ASSERT_NO_THROW(Plane(unitVec[0],unitVec[1],0));
+  CPPUNIT_ASSERT_NO_THROW(Plane(e1,e2,0));
   // and again this is actually only one vector
-  CPPUNIT_ASSERT_THROW(Plane(unitVec[0],unitVec[0],0),LinearDependenceException);
+  CPPUNIT_ASSERT_THROW(Plane(e1,e1,0),LinearDependenceException);
   // Zero vector does not give a good direction
-  CPPUNIT_ASSERT_THROW(Plane(unitVec[0],zeroVec,0),ZeroVectorException);
+  CPPUNIT_ASSERT_THROW(Plane(e1,zeroVec,0),ZeroVectorException);
 
   // use a normalvector and an scalar offset
-  CPPUNIT_ASSERT_NO_THROW(Plane(unitVec[0],0));
+  CPPUNIT_ASSERT_NO_THROW(Plane(e1,0));
   // The zero vector is no good as a normalvector
   CPPUNIT_ASSERT_THROW(Plane(zeroVec,0),ZeroVectorException);
 
   // use a normalvector and an offset vector
-  CPPUNIT_ASSERT_NO_THROW(Plane(unitVec[0],zeroVec));
+  CPPUNIT_ASSERT_NO_THROW(Plane(e1,zeroVec));
   // and the bad zeroVector again
   CPPUNIT_ASSERT_THROW(Plane(zeroVec,zeroVec),ZeroVectorException);
@@ -75 +75 @@
   {
     // construct with three points on plane
-    Plane p1(unitVec[0],unitVec[1],zeroVec);
-    CPPUNIT_ASSERT(testNormal(unitVec[2],p1.getNormal()));
+    Plane p1(e1,e2,zeroVec);
+    CPPUNIT_ASSERT(testNormal(e3,p1.getNormal()));
     CPPUNIT_ASSERT_EQUAL(0.,p1.getOffset());
 
-    Plane p2(unitVec[0],unitVec[2],zeroVec);
-    CPPUNIT_ASSERT(testNormal(unitVec[1],p2.getNormal()));
+    Plane p2(e1,e3,zeroVec);
+    CPPUNIT_ASSERT(testNormal(e2,p2.getNormal()));
     CPPUNIT_ASSERT_EQUAL(0.,p2.getOffset());
 
-    Plane p3(unitVec[1],unitVec[2],zeroVec);
-    CPPUNIT_ASSERT(testNormal(unitVec[0],p3.getNormal()));
+    Plane p3(e2,e3,zeroVec);
+    CPPUNIT_ASSERT(testNormal(e1,p3.getNormal()));
     CPPUNIT_ASSERT_EQUAL(0.,p3.getOffset());
   }
   {
     // construct with two directions + offset
-    Plane p1(unitVec[0],unitVec[1],0);
-    CPPUNIT_ASSERT(testNormal(unitVec[2],p1.getNormal()));
+    Plane p1(e1,e2,0);
+    CPPUNIT_ASSERT(testNormal(e3,p1.getNormal()));
     CPPUNIT_ASSERT_EQUAL(0.,p1.getOffset());
 
-    Plane p2(unitVec[0],unitVec[2],0);
-    CPPUNIT_ASSERT(testNormal(unitVec[1],p2.getNormal()));
+    Plane p2(e1,e3,0);
+    CPPUNIT_ASSERT(testNormal(e2,p2.getNormal()));
     CPPUNIT_ASSERT_EQUAL(0.,p2.getOffset());
 
-    Plane p3(unitVec[1],unitVec[2],0);
-    CPPUNIT_ASSERT(testNormal(unitVec[0],p3.getNormal()));
+    Plane p3(e2,e3,0);
+    CPPUNIT_ASSERT(testNormal(e1,p3.getNormal()));
     CPPUNIT_ASSERT_EQUAL(0.,p3.getOffset());
   }
@@ -145 +145 @@
 void PlaneUnittest::operationsTest(){
   {
-    Vector t = (1./3.)*(unitVec[0]+unitVec[1]+unitVec[2]);
+    Vector t = (1./3.)*(e1+e2+e3);
     CPPUNIT_ASSERT(fabs(p1->distance(zeroVec)-t.Norm()) < MYEPSILON);
     CPPUNIT_ASSERT_EQUAL(t,p1->getClosestPoint(zeroVec));
   }
 
-  CPPUNIT_ASSERT(fabs(p2->distance(unitVec[2])-1) < MYEPSILON);
-  CPPUNIT_ASSERT_EQUAL(zeroVec,p2->getClosestPoint(unitVec[2]));
-  CPPUNIT_ASSERT(fabs(p3->distance(unitVec[1])-1) < MYEPSILON);
-  CPPUNIT_ASSERT_EQUAL(zeroVec,p3->getClosestPoint(unitVec[1]));
-  CPPUNIT_ASSERT(fabs(p4->distance(unitVec[0])-1) < MYEPSILON);
-  CPPUNIT_ASSERT_EQUAL(zeroVec,p4->getClosestPoint(unitVec[0]));
+  CPPUNIT_ASSERT(fabs(p2->distance(e3)-1) < MYEPSILON);
+  CPPUNIT_ASSERT_EQUAL(zeroVec,p2->getClosestPoint(e3));
+  CPPUNIT_ASSERT(fabs(p3->distance(e2)-1) < MYEPSILON);
+  CPPUNIT_ASSERT_EQUAL(zeroVec,p3->getClosestPoint(e2));
+  CPPUNIT_ASSERT(fabs(p4->distance(e1)-1) < MYEPSILON);
+  CPPUNIT_ASSERT_EQUAL(zeroVec,p4->getClosestPoint(e1));
 }
 
@@ -162 +162 @@
 
   // some Vectors that lie on the planes
-  fixture = p1->mirrorVector(unitVec[0]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[0]);
-  fixture = p1->mirrorVector(unitVec[1]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[1]);
-  fixture = p1->mirrorVector(unitVec[2]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[2]);
+  fixture = p1->mirrorVector(e1);
+  CPPUNIT_ASSERT_EQUAL(fixture,e1);
+  fixture = p1->mirrorVector(e2);
+  CPPUNIT_ASSERT_EQUAL(fixture,e2);
+  fixture = p1->mirrorVector(e3);
+  CPPUNIT_ASSERT_EQUAL(fixture,e3);
 
   fixture = p2->mirrorVector(zeroVec);
   CPPUNIT_ASSERT_EQUAL(fixture,zeroVec);
-  fixture = p2->mirrorVector(unitVec[0]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[0]);
-  fixture = p2->mirrorVector(unitVec[1]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[1]);
+  fixture = p2->mirrorVector(e1);
+  CPPUNIT_ASSERT_EQUAL(fixture,e1);
+  fixture = p2->mirrorVector(e2);
+  CPPUNIT_ASSERT_EQUAL(fixture,e2);
 
   fixture = p3->mirrorVector(zeroVec);
   CPPUNIT_ASSERT_EQUAL(fixture,zeroVec);
-  fixture = p3->mirrorVector(unitVec[0]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[0]);
-  fixture = p3->mirrorVector(unitVec[2]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[2]);
+  fixture = p3->mirrorVector(e1);
+  CPPUNIT_ASSERT_EQUAL(fixture,e1);
+  fixture = p3->mirrorVector(e3);
+  CPPUNIT_ASSERT_EQUAL(fixture,e3);
 
   fixture = p4->mirrorVector(zeroVec);
   CPPUNIT_ASSERT_EQUAL(fixture,zeroVec);
-  fixture = p4->mirrorVector(unitVec[1]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[1]);
-  fixture = p4->mirrorVector(unitVec[2]);
-  CPPUNIT_ASSERT_EQUAL(fixture,unitVec[2]);
+  fixture = p4->mirrorVector(e2);
+  CPPUNIT_ASSERT_EQUAL(fixture,e2);
+  fixture = p4->mirrorVector(e3);
+  CPPUNIT_ASSERT_EQUAL(fixture,e3);
 
   // some Vectors outside of the planes
   {
-    Vector t = (2./3.)*(unitVec[0]+unitVec[1]+unitVec[2]);
+    Vector t = (2./3.)*(e1+e2+e3);
     fixture = p1->mirrorVector(zeroVec);
     CPPUNIT_ASSERT_EQUAL(fixture,t);
   }
 
-  fixture = p2->mirrorVector(unitVec[2]);
-  CPPUNIT_ASSERT_EQUAL(fixture,-1*unitVec[2]);
-  fixture = p3->mirrorVector(unitVec[1]);
-  CPPUNIT_ASSERT_EQUAL(fixture,-1*unitVec[1]);
-  fixture = p4->mirrorVector(unitVec[0]);
-  CPPUNIT_ASSERT_EQUAL(fixture,-1*unitVec[0]);
+  fixture = p2->mirrorVector(e3);
+  CPPUNIT_ASSERT_EQUAL(fixture,-1*e3);
+  fixture = p3->mirrorVector(e2);
+  CPPUNIT_ASSERT_EQUAL(fixture,-1*e2);
+  fixture = p4->mirrorVector(e1);
+  CPPUNIT_ASSERT_EQUAL(fixture,-1*e1);
 }
 
@@ -209 +209 @@
   // plane at (0,0,0) normal to (1,0,0) cuts line from (0,0,0) to (2,1,0) at ???
   Line l1 = makeLineThrough(zeroVec,Vector(2,1,0));
-  CPPUNIT_ASSERT_NO_THROW(fixture = Plane(unitVec[0], zeroVec).GetIntersection(l1) );
+  CPPUNIT_ASSERT_NO_THROW(fixture = Plane(e1, zeroVec).GetIntersection(l1) );
   CPPUNIT_ASSERT_EQUAL( zeroVec, fixture );
 
   // plane at (2,1,0) normal to (0,1,0) cuts line from (1,0,0) to (0,1,1) at ???
-  Line l2 = makeLineThrough(unitVec[0],Vector(0,1,1));
-  CPPUNIT_ASSERT_NO_THROW(fixture = Plane(unitVec[1], Vector(2,1,0)).GetIntersection(l2) );
+  Line l2 = makeLineThrough(e1,Vector(0,1,1));
+  CPPUNIT_ASSERT_NO_THROW(fixture = Plane(e2, Vector(2,1,0)).GetIntersection(l2) );
   CPPUNIT_ASSERT_EQUAL( Vector(0., 1., 1.), fixture );
 }