Changeset 3a21a7

Timestamp:

Dec 4, 2010, 11:42:39 PM (14 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

738ae1

Parents:

e9be39

git-author:

Frederik Heber <heber@…> (11/08/10 13:04:37)

git-committer:

Frederik Heber <heber@…> (12/04/10 23:42:39)

Message:

Moved validate() functions for boost::program_options into own module.

• removed from CommandLineParser.cpp.

Location:

src/UIElements

Files:

• CommandLineUI/CommandLineParser.cpp (modified) (6 diffs)
• CommandLineUI/CommandLineParser_validate.cpp (added)
• CommandLineUI/CommandLineParser_validate.hpp (added)
• Makefile.am (modified) (2 diffs)

src/UIElements/CommandLineUI/CommandLineParser.cpp

@@ -21 +21 @@
 
 #include <boost/filesystem.hpp>
-#include <boost/lexical_cast.hpp>
 #include <boost/program_options.hpp>
 #include <fstream>
 #include <iostream>
 #include <map>
-#include <vector>
 
 #include "Actions/Action.hpp"
@@ -34 +32 @@
 #include "Actions/OptionTrait.hpp"
 #include "Actions/Values.hpp"
-#include "Helpers/Assert.hpp"
 #include "Helpers/Log.hpp"
 #include "Helpers/Verbose.hpp"
 #include "CommandLineParser.hpp"
+#include "CommandLineParser_validate.hpp"
 
 #include "Patterns/Singleton_impl.hpp"
 
 class element;
-
-using namespace std;
-
-/** boost::program_options validator specialization for VectorValue.
- * \param &v  reference for return value
- * \param &values string vector of scanned options
- * \param *
- * \param
- *
- */
-void validate(boost::any& v, const std::vector<std::string>& values, VectorValue *, int)
-{
-  VectorValue VV;
-  std::vector<std::string> components;
-
-  // split comma-separated values
-  if (values.size() != 1) {
-    cerr <<  "Not one vector but " << values.size() << " given " << endl;
-    throw boost::program_options::validation_error("Unequal to one vector given");
-  }
-  std::string argument(values.at(0));
-  std::string::iterator Aiter = argument.begin();
-  std::string::iterator Biter = argument.begin();
-  for (; Aiter != argument.end(); ++Aiter) {
-    if (*Aiter == ',') {
-      components.push_back(string(Biter,Aiter));
-      do {
-        Aiter++;
-      } while (*Aiter == ' ' || *Aiter == '\t');
-      Biter = Aiter;
-    }
-  }
-  components.push_back(string(Biter,argument.end()));
-
-  if (components.size() != 3) {
-    cerr <<  "Specified vector does not have three components but " << components.size() << endl;
-    throw boost::program_options::validation_error("Specified vector does not have three components");
-  }
-  VV.x = boost::lexical_cast<double>(components.at(0));
-  VV.y = boost::lexical_cast<double>(components.at(1));
-  VV.z = boost::lexical_cast<double>(components.at(2));
-  v = boost::any(VectorValue(VV));
-}
-
-void validate(boost::any& v, const std::vector<std::string>& values, BoxValue *, int)
-{
-  BoxValue BV;
-  std::vector<std::string> components;
-
-  // split comma-separated values
-  if (values.size() != 1) {
-    cerr <<  "Not one vector but " << values.size() << " given " << endl;
-    throw boost::program_options::validation_error("Unequal to one vector given");
-  }
-  std::string argument(values.at(0));
-  std::string::iterator Aiter = argument.begin();
-  std::string::iterator Biter = argument.begin();
-  for (; Aiter != argument.end(); ++Aiter) {
-    if (*Aiter == ',') {
-      components.push_back(string(Biter,Aiter));
-      do {
-        Aiter++;
-      } while (*Aiter == ' ' || *Aiter == '\t');
-      Biter = Aiter;
-    }
-  }
-  components.push_back(string(Biter,argument.end()));
-
-  if (components.size() != 6) {
-    cerr <<  "Specified vector does not have three components but " << components.size() << endl;
-    throw boost::program_options::validation_error("Specified symmetric box matrix does not have six components");
-  }
-  BV.xx = boost::lexical_cast<double>(components.at(0));
-  BV.yx = boost::lexical_cast<double>(components.at(1));
-  BV.yy = boost::lexical_cast<double>(components.at(2));
-  BV.zx = boost::lexical_cast<double>(components.at(3));
-  BV.zy = boost::lexical_cast<double>(components.at(4));
-  BV.zz = boost::lexical_cast<double>(components.at(5));
-  v = boost::any(BoxValue(BV));
-}
-
-/** boost::program_options validator specialization for boost::filesystem::path.
- * \param &v  reference for return value
- * \param &values string vector of scanned options
- * \param *
- * \param
- *
- */
-void validate(boost::any& v, const std::vector<std::string>& values, boost::filesystem::path *, int)
-{
-  boost::filesystem::path filename;
-
-  std::cout << "boost::filesystem::path validator used." << std::endl;
-
-  // split comma-separated values
-  if (values.size() != 1) {
-    cerr <<  "Not one file but " << values.size() << " given " << endl;
-    throw boost::program_options::validation_error("Unequal to one file given");
-  }
-  filename = values.at(0);
-  v = boost::any(boost::filesystem::path(filename));
-}
-
 
 /** Constructor of class CommandLineParser.
@@ -461 +356 @@
 {
   po::store(po::command_line_parser(argc,argv).options(cmdline_options).run(), vm);
-  ifstream input;
+  std::ifstream input;
   input.open("example.cfg");
   if (!input.fail())
@@ -473 +368 @@
 void CommandLineParser::scanforSequenceOfArguments()
 {
-  map <std::string, std::string> ShortFormToActionMap = getShortFormToActionMap();
+  std::map <std::string, std::string> ShortFormToActionMap = getShortFormToActionMap();
   // go through all arguments
   for (int i=1;i<argc;i++) {
-    (cout << Verbose(1) << "Checking on " << argv[i] << endl);
+    (std::cout << Verbose(1) << "Checking on " << argv[i] << std::endl);
     // check whether they
     if (argv[i][0] == '-') { // .. begin with -
@@ -485 +380 @@
         //  .. and check that next letter is not numeric, if so insert
       } else if (((argv[i][1] < '0') || (argv[i][1] > '9')) && ((argv[i][1] != '.'))) {
-        map <std::string, std::string>::iterator iter = ShortFormToActionMap.find(&(argv[i][1]));
+        std::map <std::string, std::string>::iterator iter = ShortFormToActionMap.find(&(argv[i][1]));
         if (iter != ShortFormToActionMap.end()) {
           (cout << Verbose(1) << "Putting " << iter->second << " for " << iter->first << " into the sequence." << endl);
@@ -511 +406 @@
 std::map <std::string, std::string> CommandLineParser::getShortFormToActionMap()
 {
-  map <std::string, std::string> result;
+  std::map <std::string, std::string> result;
 
   ActionRegistry &AR = ActionRegistry::getInstance();

src/UIElements/Makefile.am

@@ -134 +134 @@
   CommandLineUI/CommandLineDialog.cpp \
   CommandLineUI/CommandLineParser.cpp \
+  CommandLineUI/CommandLineParser_validate.cpp \
   CommandLineUI/CommandLineStatusIndicator.cpp \
   CommandLineUI/CommandLineUIFactory.cpp \
@@ -142 +143 @@
   CommandLineUI/CommandLineDialog.hpp \
   CommandLineUI/CommandLineParser.hpp \
+  CommandLineUI/CommandLineParser_validate.hpp \
   CommandLineUI/CommandLineStatusIndicator.hpp \
   CommandLineUI/CommandLineUIFactory.hpp \