Changeset 3308b6

Timestamp:

Oct 17, 2011, 2:31:00 PM (13 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

a7d753

Parents:

e09d67

git-author:

Frederik Heber <heber@…> (09/29/11 11:03:29)

git-committer:

Frederik Heber <heber@…> (10/17/11 14:31:00)

Message:

FIX: 3 out of 4 unit tests have not been told to throw AssertException instead of abort.

Location:

src

Files:

• Parser/unittests/ParserMpqcUnitTest.cpp (modified) (2 diffs)
• unittests/BoxUnitTest.cpp (modified) (1 diff)
• unittests/FormulaUnitTest.cpp (modified) (1 diff)

src/Parser/unittests/ParserMpqcUnitTest.cpp

@@ -158 +158 @@
 )\n"; // basically tested with mpqc 3.0.0-alpha (no parse errors but did not calculate due to missing code)
 
-void ParserMpqcUnitTest::setUp() {
+void ParserMpqcUnitTest::setUp() 
+{
+  // failing asserts should be thrown
+  ASSERT_DO(Assert::Throw);
+
   parser = new FormatParser<mpqc>();
 
@@ -170 +174 @@
 }
 
-void ParserMpqcUnitTest::tearDown() {
+void ParserMpqcUnitTest::tearDown() 
+{
   delete parser;
   ChangeTracker::purgeInstance();

src/unittests/BoxUnitTest.cpp

@@ -39 +39 @@
 
 void BoxUnittest::setUp(){
+  // failing asserts should be thrown
   ASSERT_DO(Assert::Throw);
+
   unit = new RealSpaceMatrix;
   unit->setIdentity();

src/unittests/FormulaUnitTest.cpp

@@ -35 +35 @@
 CPPUNIT_TEST_SUITE_REGISTRATION( FormulaUnittest );
 
-void FormulaUnittest::setUp(){}
-void FormulaUnittest::tearDown(){
+void FormulaUnittest::setUp()
+{
+  // failing asserts should be thrown
+  ASSERT_DO(Assert::Throw);
+}
+
+void FormulaUnittest::tearDown()
+{
   World::purgeInstance();
 }