Changes in src/Actions/MoleculeAction/RotateAroundSelfByAngleAction.cpp [90bc51:2204b0]

File:

• src/Actions/MoleculeAction/RotateAroundSelfByAngleAction.cpp (modified) (7 diffs)

src/Actions/MoleculeAction/RotateAroundSelfByAngleAction.cpp

@@ -34 +34 @@
 class MoleculeRotateAroundSelfByAngleState : public ActionState {
 public:
-    MoleculeRotateAroundSelfByAngleState(molecule * const _mol, const Vector &_Axis, const double _alpha) :
+    MoleculeRotateAroundSelfByAngleState(molecule * const _mol, const double _alpha) :
       mol(_mol),
-      Axis(_Axis),
       alpha(_alpha)
     {}
     molecule* const mol;
-    Vector Axis;
     double alpha;
 };
@@ -53 +51 @@
 {}
 
-void MoleculeRotateAroundSelfByAngle(const Vector &Axis, const double angle) {
+void MoleculeRotateAroundSelfByAngle(double angle) {
   ValueStorage::getInstance().setCurrentValue(MoleculeRotateAroundSelfByAngleAction::NAME, angle);
-  ValueStorage::getInstance().setCurrentValue("position", Axis);
   ActionRegistry::getInstance().getActionByName(MoleculeRotateAroundSelfByAngleAction::NAME)->call(Action::NonInteractive);
 };
@@ -63 +60 @@
 
   dialog->queryDouble(NAME, MapOfActions::getInstance().getDescription(NAME));
-  dialog->queryVector("position", false, MapOfActions::getInstance().getDescription(NAME));
 
   return dialog;
@@ -71 +67 @@
   molecule *mol = NULL;
   double alpha = 0.;
-  Vector Axis;
 
-  // obtain angle and axis around which rotate
+  // obtain angle around which rotate
   ValueStorage::getInstance().queryCurrentValue(NAME, alpha);
-  ValueStorage::getInstance().queryCurrentValue("position", Axis);
 
   // check whether a single atom and molecule is selected
-  if (World::getInstance().getSelectedMolecules().size() != 1)
-    return Action::failure;
-  mol = World::getInstance().beginMoleculeSelection()->second;
-
-  // check whether Axis is valid
-  if (Axis.IsZero())
+  if ((World::getInstance().getSelectedAtoms().size() != 1) || (World::getInstance().getSelectedMolecules().size() != 1))
     return Action::failure;
 
-  // convert from degrees to radian
-  alpha *= M_PI/180.;
+  DoLog(0) && (Log() << Verbose(0) << "Rotate around self by " << alpha << "." << endl);
+  mol = World::getInstance().beginMoleculeSelection()->second;
 
   // Creation Line that is the rotation axis
   Vector *CenterOfGravity = mol->DetermineCenterOfGravity();
-  Line RotationAxis(*CenterOfGravity, Axis);
+  Line RotationAxis(*CenterOfGravity, (World::getInstance().beginAtomSelection()->second)->x);
   delete(CenterOfGravity);
-  DoLog(0) && (Log() << Verbose(0) << "Rotate around self by " << alpha << " along " << RotationAxis << "." << endl);
 
   for (molecule::iterator iter = mol->begin(); iter != mol->end(); ++iter) {
@@ -100 +88 @@
   DoLog(0) && (Log() << Verbose(0) << "done." << endl);
 
-  return Action::state_ptr(new MoleculeRotateAroundSelfByAngleState(mol, Axis, alpha));
+  return Action::state_ptr(new MoleculeRotateAroundSelfByAngleState(mol, alpha));
 }
 
@@ -107 +95 @@
 
   Vector *CenterOfGravity = state->mol->DetermineCenterOfGravity();
-  Line RotationAxis(*CenterOfGravity, state->Axis);
+  Line RotationAxis(*CenterOfGravity, (World::getInstance().beginAtomSelection()->second)->x);
   delete(CenterOfGravity);
 
@@ -121 +109 @@
 
   Vector *CenterOfGravity = state->mol->DetermineCenterOfGravity();
-  Line RotationAxis(*CenterOfGravity, state->Axis);
+  Line RotationAxis(*CenterOfGravity, (World::getInstance().beginAtomSelection()->second)->x);
   delete(CenterOfGravity);