Changeset 19290f

Timestamp:

Mar 7, 2011, 11:40:27 AM (14 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

197e13

Parents:

c6e5eb

git-author:

Frederik Heber <heber@…> (03/02/11 13:12:54)

git-committer:

Frederik Heber <heber@…> (03/07/11 11:40:27)

Message:

Added CommandLineParser_ActionRegistry_ConsistenyUnitTest to check whether Actions have menus not listed in CommandLineParser.

• Menus may be added to Actions and there is so far no check on whether CommandLineParser knows about this Menu (it needs a respective program_options map).

Files:

• configure.ac (modified) (1 diff)
• src/UIElements/CommandLineUI/CommandLineParser.hpp (modified) (2 diffs)
• src/UIElements/CommandLineUI/unittests/CommandLineParser_ActionRegistry_ConsistenyUnitTest.cpp (added)
• src/UIElements/CommandLineUI/unittests/CommandLineParser_ActionRegistry_ConsistenyUnitTest.hpp (added)
• src/UIElements/CommandLineUI/unittests/Makefile.am (added)
• src/unittests/Makefile.am (modified) (3 diffs)

configure.ac

@@ -236 +236 @@
   src/RandomNumbers/unittests/Makefile
   src/Shapes/unittests/Makefile
+  src/UIElements/CommandLineUI/unittests/Makefile
         src/UIElements/Menu/unittests/Makefile
 ])

src/UIElements/CommandLineUI/CommandLineParser.hpp

@@ -25 +25 @@
 
 class Action;
+class CommandLineParser_ActionRegistry_ConsistenyTest;
 class OptionTrait;
 
@@ -99 +100 @@
 class CommandLineParser : public Singleton<CommandLineParser> {
   friend class Singleton<CommandLineParser>;
+
+  //!> test needs to access CmdParserLookup to see whether menus are missing
+  friend class CommandLineParser_ActionRegistry_ConsistenyTest;
 public:
 

src/unittests/Makefile.am

@@ -9 +9 @@
         ../RandomNumbers/unittests \
         ../Shapes/unittests \
+        ../UIElements/CommandLineUI/unittests \
         ../UIElements/Menu/unittests
 
@@ -76 +77 @@
   ../LinearAlgebra/unittests/MatrixContentUnitTest.cpp \
   ../LinearAlgebra/unittests/MatrixUnitTest.cpp \
+  ../UIElements/CommandLineUI/unittests/CommandLineParser_ActionRegistry_ConsistenyUnitTest.cpp \
   ../UIElements/Menu/unittests/MenuDescriptionUnitTest.cpp \
   ../Descriptors/unittests/MoleculeDescriptorUnitTest.cpp \
@@ -114 +116 @@
   ../LinearAlgebra/unittests/MatrixContentUnitTest.hpp \
   ../LinearAlgebra/unittests/MatrixUnitTest.hpp \
+  ../UIElements/CommandLineUI/unittests/CommandLineParser_ActionRegistry_ConsistenyUnitTest.hpp \
   ../UIElements/Menu/unittests/MenuDescriptionUnitTest.hpp \
   ../Descriptors/unittests/MoleculeDescriptorUnitTest.hpp \