Changeset 06f41f3 for src/Graph/unittests

Timestamp:

Dec 3, 2012, 9:49:30 AM (12 years ago)

Author:

Frederik Heber <heber@…>

Branches:

Action_Thermostats, Add_AtomRandomPerturbation, Add_FitFragmentPartialChargesAction, Add_RotateAroundBondAction, Add_SelectAtomByNameAction, Added_ParseSaveFragmentResults, AddingActions_SaveParseParticleParameters, Adding_Graph_to_ChangeBondActions, Adding_MD_integration_tests, Adding_ParticleName_to_Atom, Adding_StructOpt_integration_tests, AtomFragments, Automaking_mpqc_open, AutomationFragmentation_failures, Candidate_v1.5.4, Candidate_v1.6.0, Candidate_v1.6.1, ChangeBugEmailaddress, ChangingTestPorts, ChemicalSpaceEvaluator, CombiningParticlePotentialParsing, Combining_Subpackages, Debian_Package_split, Debian_package_split_molecuildergui_only, Disabling_MemDebug, Docu_Python_wait, EmpiricalPotential_contain_HomologyGraph, EmpiricalPotential_contain_HomologyGraph_documentation, Enable_parallel_make_install, Enhance_userguide, Enhanced_StructuralOptimization, Enhanced_StructuralOptimization_continued, Example_ManyWaysToTranslateAtom, Exclude_Hydrogens_annealWithBondGraph, FitPartialCharges_GlobalError, Fix_BoundInBox_CenterInBox_MoleculeActions, Fix_ChargeSampling_PBC, Fix_ChronosMutex, Fix_FitPartialCharges, Fix_FitPotential_needs_atomicnumbers, Fix_ForceAnnealing, Fix_IndependentFragmentGrids, Fix_ParseParticles, Fix_ParseParticles_split_forward_backward_Actions, Fix_PopActions, Fix_QtFragmentList_sorted_selection, Fix_Restrictedkeyset_FragmentMolecule, Fix_StatusMsg, Fix_StepWorldTime_single_argument, Fix_Verbose_Codepatterns, Fix_fitting_potentials, Fixes, ForceAnnealing_goodresults, ForceAnnealing_oldresults, ForceAnnealing_tocheck, ForceAnnealing_with_BondGraph, ForceAnnealing_with_BondGraph_continued, ForceAnnealing_with_BondGraph_continued_betteresults, ForceAnnealing_with_BondGraph_contraction-expansion, FragmentAction_writes_AtomFragments, FragmentMolecule_checks_bonddegrees, GeometryObjects, Gui_Fixes, Gui_displays_atomic_force_velocity, ImplicitCharges, IndependentFragmentGrids, IndependentFragmentGrids_IndividualZeroInstances, IndependentFragmentGrids_IntegrationTest, IndependentFragmentGrids_Sole_NN_Calculation, JobMarket_RobustOnKillsSegFaults, JobMarket_StableWorkerPool, JobMarket_unresolvable_hostname_fix, MoreRobust_FragmentAutomation, ODR_violation_mpqc_open, PartialCharges_OrthogonalSummation, PdbParser_setsAtomName, PythonUI_with_named_parameters, QtGui_reactivate_TimeChanged_changes, Recreated_GuiChecks, Rewrite_FitPartialCharges, RotateToPrincipalAxisSystem_UndoRedo, SaturateAtoms_findBestMatching, SaturateAtoms_singleDegree, StoppableMakroAction, Subpackage_CodePatterns, Subpackage_JobMarket, Subpackage_LinearAlgebra, Subpackage_levmar, Subpackage_mpqc_open, Subpackage_vmg, Switchable_LogView, ThirdParty_MPQC_rebuilt_buildsystem, TrajectoryDependenant_MaxOrder, TremoloParser_IncreasedPrecision, TremoloParser_MultipleTimesteps, TremoloParser_setsAtomName, Ubuntu_1604_changes, stable

Children:

9511c7

Parents:

b78dfd

git-author:

Frederik Heber <heber@…> (09/19/12 13:55:43)

git-committer:

Frederik Heber <heber@…> (12/03/12 09:49:30)

Message:

CheckAgainstAdjacencyFile now works on given vector of atomids.

• added helper function getGlobalIdsFromLocalIds() as we have to translate molecule's internal ids to global atomId_t to check against those in file.
• TESTFIX: Adapted CheckAgainstAdjacencyFileUnitTest to the changes, also added another test case to operatorTest().

Location:

src/Graph/unittests

Files:

• CheckAgainstAdjacencyFileUnitTest.cpp (modified) (8 diffs)
• CheckAgainstAdjacencyFileUnitTest.hpp (modified) (3 diffs)

src/Graph/unittests/CheckAgainstAdjacencyFileUnitTest.cpp

@@ -39 +39 @@
 #include <cppunit/ui/text/TestRunner.h>
 
+#include <boost/lambda/lambda.hpp>
 #include <iostream>
-#include <string>
+#include <iterator>
+#include <iostream>
+#include <vector>
 
 #include "CodePatterns/Assert.hpp"
@@ -76 +79 @@
 static std::string wrongadjacencyfile1 ="\
 1 2\n\
-2 1 3\n\
-4 3 5\n\
+2 1\n\
+4 5\n\
 5 4 6\n\
 6 5 7\n\
@@ -98 +101 @@
 11 10";
 
+static std::string wrongadjacencyfile3 ="\
+1 2\n\
+2 1 3\n\
+3 2 4\n\
+4 3 5\n\
+5 4 7\n\
+6\n\
+7 5 8\n\
+8 7 9\n\
+9 8 10\n\
+10 9 11\n\
+11 10";
+
 // set up and tear down
 void CheckAgainstAdjacencyFileTest::setUp()
@@ -110 +126 @@
   CPPUNIT_ASSERT(TestMolecule != NULL);
   for(int i=0;i<ATOM_COUNT;++i){
-    atoms[i]= World::getInstance().createAtom();
-    CPPUNIT_ASSERT(atoms[i] != NULL);
-    atoms[i]->setType(hydrogen);
-    TestMolecule->AddAtom(atoms[i]);
-    atomIds[i]= atoms[i]->getId();
-  }
+    atom *_atom = World::getInstance().createAtom();
+    CPPUNIT_ASSERT(_atom != NULL);
+    _atom->setType(hydrogen);
+    TestMolecule->AddAtom(_atom);
+    atoms.push_back(_atom);
+    atomIds.push_back(_atom->getId());
+  }
+  CPPUNIT_ASSERT_EQUAL( (size_t)ATOM_COUNT, atoms.size());
+  CPPUNIT_ASSERT_EQUAL( (size_t)ATOM_COUNT, atomIds.size());
   // create linear chain
-  for(int i=0;i<ATOM_COUNT-1;++i){
+  for(int i=0;i<ATOM_COUNT-1;++i)
     atoms[i]->addBond(WorldTime::getTime(), atoms[i+1]);
-  }
 
   // create map as it should be
@@ -143 +161 @@
 }
 
-/** Unit tests for CheckAgainstAdjacencyFile::CreateInternalMap().
- *
- */
-void CheckAgainstAdjacencyFileTest::CreateInternalMapTest()
+/** Unit tests for CheckAgainstAdjacencyFile::CreateExternalMap().
+ *
+ */
+void CheckAgainstAdjacencyFileTest::CreateExternalMapTest()
 {
   std::stringstream input;
   CheckAgainstAdjacencyFile fileChecker(input);
-  World::getInstance().selectAllAtoms(AllAtoms());
-  const World &world = World::getInstance();
-  fileChecker.CreateInternalMap(world.beginAtomSelection(), world.endAtomSelection());
+  fileChecker.CreateExternalMap(atomIds);
 
   // check size (it's 8*2 + 2*1 = 18 keys)
+  CPPUNIT_ASSERT_EQUAL( (size_t)18, fileChecker.ExternalAtomBondMap.size() );
+  CPPUNIT_ASSERT_EQUAL( (size_t)0, fileChecker.InternalAtomBondMap.size() );
+
+  // check equality
+  CPPUNIT_ASSERT( comparisonMap.size() == fileChecker.ExternalAtomBondMap.size() );
+//  std::cout << "comparisonMap: " << comparisonMap << std::endl;
+//  std::cout << "fileChecker.InternalAtomBondMap: " << fileChecker.InternalAtomBondMap << std::endl;
+  CPPUNIT_ASSERT( comparisonMap == fileChecker.ExternalAtomBondMap );
+
+  // check non-equality: more
+  comparisonMap.insert( std::make_pair( (atomId_t)10, (atomId_t)8) );
+  CPPUNIT_ASSERT( comparisonMap != fileChecker.ExternalAtomBondMap );
+  comparisonMap.erase((atomId_t)10);
+
+  // check non-equality: less
+  comparisonMap.erase((atomId_t)9);
+  CPPUNIT_ASSERT( comparisonMap != fileChecker.ExternalAtomBondMap );
+}
+
+/** Unit tests for CheckAgainstAdjacencyFile::ParseInInternalMap().
+ *
+ */
+void CheckAgainstAdjacencyFileTest::ParseInInternalMapTest()
+{
+  std::stringstream input(adjacencyfile);
+  CheckAgainstAdjacencyFile fileChecker(input);
+  std::vector<atomId_t> noids;
+  fileChecker.CreateExternalMap(noids);
+
+  // check size (it's 8*2 + 2*1 = 18 keys)
+  CPPUNIT_ASSERT_EQUAL( (size_t)0, fileChecker.ExternalAtomBondMap.size() );
   CPPUNIT_ASSERT_EQUAL( (size_t)18, fileChecker.InternalAtomBondMap.size() );
-  CPPUNIT_ASSERT_EQUAL( (size_t)0, fileChecker.ExternalAtomBondMap.size() );
 
   // check equality
   CPPUNIT_ASSERT( comparisonMap.size() == fileChecker.InternalAtomBondMap.size() );
-//  std::cout << "comparisonMap: " << comparisonMap << std::endl;
-//  std::cout << "fileChecker.InternalAtomBondMap: " << fileChecker.InternalAtomBondMap << std::endl;
   CPPUNIT_ASSERT( comparisonMap == fileChecker.InternalAtomBondMap );
 
@@ -174 +218 @@
 }
 
-/** Unit tests for CheckAgainstAdjacencyFile::ParseInExternalMap().
- *
- */
-void CheckAgainstAdjacencyFileTest::ParseInExternalMapTest()
-{
-  std::stringstream input(adjacencyfile);
-  World::getInstance().selectAllAtoms(NoAtoms());
-  CheckAgainstAdjacencyFile fileChecker(input);
-  fileChecker.CreateInternalMap(World::getInstance().beginAtomSelection(), World::getInstance().endAtomSelection());
-
-  // check size (it's 8*2 + 2*1 = 18 keys)
-  CPPUNIT_ASSERT_EQUAL( (size_t)0, fileChecker.InternalAtomBondMap.size() );
-  CPPUNIT_ASSERT_EQUAL( (size_t)18, fileChecker.ExternalAtomBondMap.size() );
-
-  // check equality
-  CPPUNIT_ASSERT( comparisonMap.size() == fileChecker.ExternalAtomBondMap.size() );
-  CPPUNIT_ASSERT( comparisonMap == fileChecker.ExternalAtomBondMap );
-
-  // check non-equality: more
-  comparisonMap.insert( std::make_pair( (atomId_t)10, (atomId_t)8) );
-  CPPUNIT_ASSERT( comparisonMap != fileChecker.ExternalAtomBondMap );
-  comparisonMap.erase((atomId_t)10);
-
-  // check non-equality: less
-  comparisonMap.erase((atomId_t)9);
-  CPPUNIT_ASSERT( comparisonMap != fileChecker.ExternalAtomBondMap );
-}
-
 /** Unit tests for CheckAgainstAdjacencyFile::CompareInternalExternalMap().
  *
@@ -210 +226 @@
   CheckAgainstAdjacencyFile fileChecker(input);
 
-  // assert non-equality before parsing
-  CPPUNIT_ASSERT( fileChecker.InternalAtomBondMap.size() != fileChecker.ExternalAtomBondMap.size() );
-  CPPUNIT_ASSERT( fileChecker.InternalAtomBondMap != fileChecker.ExternalAtomBondMap );
-  CPPUNIT_ASSERT( !fileChecker.CompareInternalExternalMap() );
-
-  // parse
-  World::getInstance().selectAllAtoms(AllAtoms());
-  fileChecker.CreateInternalMap(World::getInstance().beginAtomSelection(), World::getInstance().endAtomSelection());
+  // assert equality before parsing (empty sets should always return true)
+  CPPUNIT_ASSERT( fileChecker.ExternalAtomBondMap.size() != fileChecker.InternalAtomBondMap.size() );
+  CPPUNIT_ASSERT( fileChecker.ExternalAtomBondMap != fileChecker.InternalAtomBondMap );
+  CPPUNIT_ASSERT( fileChecker.CompareInternalExternalMap() );
+
+  // parse in external map
+  fileChecker.CreateExternalMap(atomIds);
 
   // assert equality after parsing
-  CPPUNIT_ASSERT_EQUAL( fileChecker.InternalAtomBondMap.size(), fileChecker.ExternalAtomBondMap.size() );
-  CPPUNIT_ASSERT_EQUAL( fileChecker.InternalAtomBondMap, fileChecker.ExternalAtomBondMap );
+  CPPUNIT_ASSERT_EQUAL( fileChecker.ExternalAtomBondMap.size(), fileChecker.InternalAtomBondMap.size() );
+  CPPUNIT_ASSERT_EQUAL( fileChecker.ExternalAtomBondMap, fileChecker.InternalAtomBondMap );
   CPPUNIT_ASSERT( fileChecker.CompareInternalExternalMap() );
 }
@@ -230 +245 @@
 void CheckAgainstAdjacencyFileTest::operatorTest()
 {
-  World::getInstance().selectAllAtoms(AllAtoms());
   {
     // parse right
     std::stringstream input(adjacencyfile);
     CheckAgainstAdjacencyFile fileChecker(input);
-    CPPUNIT_ASSERT( fileChecker(World::getInstance().beginAtomSelection(), World::getInstance().endAtomSelection()) );
-  }
-  {
-    // parse wrong1
+    CPPUNIT_ASSERT( fileChecker(atomIds) );
+  }
+  {
+    // parse wrong1 (more atoms in the world than in file, hence wrong)
     std::stringstream input(wrongadjacencyfile1);
     CheckAgainstAdjacencyFile fileChecker(input);
-    CPPUNIT_ASSERT( !fileChecker(World::getInstance().beginAtomSelection(), World::getInstance().endAtomSelection()) );
-  }
-  {
-    // parse wrong2 (there is no atom 10)
+    CPPUNIT_ASSERT( !fileChecker(atomIds) );
+  }
+  {
+    // remove third atom (index starts at 0) and test for equality then
+    std::vector<atomId_t> validids;
+    std::remove_copy_if(atomIds.begin(), atomIds.end(), std::back_inserter(validids), boost::lambda::_1 == (atomId_t)2);
+    CPPUNIT_ASSERT_EQUAL( (size_t)ATOM_COUNT-1, validids.size() );
+    // parse wrong1 (more atoms in the world than in file, hence wrong)
+    std::stringstream input(wrongadjacencyfile1);
+    CheckAgainstAdjacencyFile fileChecker(input);
+    CPPUNIT_ASSERT( fileChecker(validids) );
+  }
+  {
+    // parse wrong2 (there is no atom 10, but present in file. hence true)
     std::stringstream input(wrongadjacencyfile2);
-#ifndef NDEBUG
-    std::cout << "The following Assert failures are intended and do not indicate a failure of the test." << std::endl;
-    CPPUNIT_ASSERT_THROW( CheckAgainstAdjacencyFile fileChecker(input), Assert::AssertionFailure );
-#else
-    CheckAgainstAdjacencyFile fileChecker(input);
-    CPPUNIT_ASSERT( !fileChecker(World::getInstance().beginAtomSelection(), World::getInstance().endAtomSelection()) );
-#endif
-  }
-}
+    CheckAgainstAdjacencyFile fileChecker(input);
+    CPPUNIT_ASSERT( !fileChecker(atomIds) );
+  }
+  {
+    // parse wrong3 (6 is not connected)
+    std::stringstream input(wrongadjacencyfile3);
+    CheckAgainstAdjacencyFile fileChecker(input);
+    CPPUNIT_ASSERT( !fileChecker(atomIds) );
+  }
+}

src/Graph/unittests/CheckAgainstAdjacencyFileUnitTest.hpp

@@ -30 +30 @@
 {
   CPPUNIT_TEST_SUITE( CheckAgainstAdjacencyFileTest );
-  CPPUNIT_TEST ( CreateInternalMapTest );
-  CPPUNIT_TEST ( ParseInExternalMapTest );
+  CPPUNIT_TEST ( CreateExternalMapTest );
+  CPPUNIT_TEST ( ParseInInternalMapTest );
   CPPUNIT_TEST ( CompareInternalExternalMapTest );
   CPPUNIT_TEST ( operatorTest );
@@ -40 +40 @@
   void tearDown();
 
-  void CreateInternalMapTest();
-  void ParseInExternalMapTest();
+  void CreateExternalMapTest();
+  void ParseInInternalMapTest();
   void CompareInternalExternalMapTest();
   void operatorTest();
@@ -47 +47 @@
 private:
   CheckAgainstAdjacencyFile::AtomBondMap comparisonMap;
-  atom *atoms [ATOM_COUNT];
-  atomId_t atomIds [ATOM_COUNT];
+  std::vector<atom *> atoms;
+  std::vector<atomId_t> atomIds;
   molecule * TestMolecule;
 };