source: src/bondgraph.cpp@ dfe8ef

Action_Thermostats Add_AtomRandomPerturbation Add_FitFragmentPartialChargesAction Add_RotateAroundBondAction Add_SelectAtomByNameAction Added_ParseSaveFragmentResults AddingActions_SaveParseParticleParameters Adding_Graph_to_ChangeBondActions Adding_MD_integration_tests Adding_ParticleName_to_Atom Adding_StructOpt_integration_tests AtomFragments Automaking_mpqc_open AutomationFragmentation_failures Candidate_v1.5.4 Candidate_v1.6.0 Candidate_v1.6.1 ChangeBugEmailaddress ChangingTestPorts ChemicalSpaceEvaluator CombiningParticlePotentialParsing Combining_Subpackages Debian_Package_split Debian_package_split_molecuildergui_only Disabling_MemDebug Docu_Python_wait EmpiricalPotential_contain_HomologyGraph EmpiricalPotential_contain_HomologyGraph_documentation Enable_parallel_make_install Enhance_userguide Enhanced_StructuralOptimization Enhanced_StructuralOptimization_continued Example_ManyWaysToTranslateAtom Exclude_Hydrogens_annealWithBondGraph FitPartialCharges_GlobalError Fix_BoundInBox_CenterInBox_MoleculeActions Fix_ChargeSampling_PBC Fix_ChronosMutex Fix_FitPartialCharges Fix_FitPotential_needs_atomicnumbers Fix_ForceAnnealing Fix_IndependentFragmentGrids Fix_ParseParticles Fix_ParseParticles_split_forward_backward_Actions Fix_PopActions Fix_QtFragmentList_sorted_selection Fix_Restrictedkeyset_FragmentMolecule Fix_StatusMsg Fix_StepWorldTime_single_argument Fix_Verbose_Codepatterns Fix_fitting_potentials Fixes ForceAnnealing_goodresults ForceAnnealing_oldresults ForceAnnealing_tocheck ForceAnnealing_with_BondGraph ForceAnnealing_with_BondGraph_continued ForceAnnealing_with_BondGraph_continued_betteresults ForceAnnealing_with_BondGraph_contraction-expansion FragmentAction_writes_AtomFragments FragmentMolecule_checks_bonddegrees GeometryObjects Gui_Fixes Gui_displays_atomic_force_velocity ImplicitCharges IndependentFragmentGrids IndependentFragmentGrids_IndividualZeroInstances IndependentFragmentGrids_IntegrationTest IndependentFragmentGrids_Sole_NN_Calculation JobMarket_RobustOnKillsSegFaults JobMarket_StableWorkerPool JobMarket_unresolvable_hostname_fix MoreRobust_FragmentAutomation ODR_violation_mpqc_open PartialCharges_OrthogonalSummation PdbParser_setsAtomName PythonUI_with_named_parameters QtGui_reactivate_TimeChanged_changes Recreated_GuiChecks Rewrite_FitPartialCharges RotateToPrincipalAxisSystem_UndoRedo SaturateAtoms_findBestMatching SaturateAtoms_singleDegree StoppableMakroAction Subpackage_CodePatterns Subpackage_JobMarket Subpackage_LinearAlgebra Subpackage_levmar Subpackage_mpqc_open Subpackage_vmg Switchable_LogView ThirdParty_MPQC_rebuilt_buildsystem TrajectoryDependenant_MaxOrder TremoloParser_IncreasedPrecision TremoloParser_MultipleTimesteps TremoloParser_setsAtomName Ubuntu_1604_changes stable
Last change on this file since dfe8ef was dfe8ef, checked in by Frederik Heber <heber@…>, 15 years ago

BUGFIX: CountHydrogenBridgeBonds() was half-broken, CountBondsOfThree() double-counted.

  • CountBondsOfThree() was counting O-H molecules as having a H-O-H and also a O-H-O triple bond because of a missing break.
  • CountHydrogenBridgeBonds() was broken in several places:
    • Checking for Hydrogen on the other oxygen atom is not part of the criteria by Marry, Rotenberg and Turq.
    • HydrogenFlag could have been set by previous atom making next hydrogen also a h-bridge bond.

Found thanks to newly implemented unit test CountBondsUnitTest.

Signed-off-by: Frederik Heber <heber@…>

  • Property mode set to 100644
File size: 12.2 KB
Line 
1/*
2 * bondgraph.cpp
3 *
4 * Created on: Oct 29, 2009
5 * Author: heber
6 */
7
8#include <iostream>
9
10#include "atom.hpp"
11#include "bond.hpp"
12#include "bondgraph.hpp"
13#include "element.hpp"
14#include "info.hpp"
15#include "log.hpp"
16#include "molecule.hpp"
17#include "parser.hpp"
18#include "periodentafel.hpp"
19#include "vector.hpp"
20
21/** Constructor of class BondGraph.
22 * This classes contains typical bond lengths and thus may be used to construct a bond graph for a given molecule.
23 */
24BondGraph::BondGraph(bool IsA) : BondLengthMatrix(NULL), max_distance(0), IsAngstroem(IsA)
25{
26};
27
28/** Destructor of class BondGraph.
29 */
30BondGraph::~BondGraph()
31{
32 if (BondLengthMatrix != NULL) {
33 delete(BondLengthMatrix);
34 }
35};
36
37/** Parses the bond lengths in a given file and puts them int a matrix form.
38 * Allocates \a MatrixContainer for BondGraph::BondLengthMatrix, using MatrixContainer::ParseMatrix(),
39 * but only if parsing is successful. Otherwise variable is left as NULL.
40 * \param *out output stream for debugging
41 * \param filename file with bond lengths to parse
42 * \return true - success in parsing file, false - failed to parse the file
43 */
44bool BondGraph::LoadBondLengthTable(const string &filename)
45{
46 Info FunctionInfo(__func__);
47 bool status = true;
48 MatrixContainer *TempContainer = NULL;
49
50 // allocate MatrixContainer
51 if (BondLengthMatrix != NULL) {
52 Log() << Verbose(1) << "MatrixContainer for Bond length already present, removing." << endl;
53 delete(BondLengthMatrix);
54 }
55 TempContainer = new MatrixContainer;
56
57 // parse in matrix
58 if (status = TempContainer->ParseMatrix(filename.c_str(), 0, 1, 0)) {
59 Log() << Verbose(1) << "Parsing bond length matrix successful." << endl;
60 } else {
61 DoeLog(1) && (eLog()<< Verbose(1) << "Parsing bond length matrix failed." << endl);
62 }
63
64 // find greatest distance
65 max_distance=0;
66 if (status) {
67 for(int i=0;i<TempContainer->RowCounter[0];i++)
68 for(int j=i;j<TempContainer->ColumnCounter[0];j++)
69 if (TempContainer->Matrix[0][i][j] > max_distance)
70 max_distance = TempContainer->Matrix[0][i][j];
71 }
72
73 if (status) // set to not NULL only if matrix was parsed
74 BondLengthMatrix = TempContainer;
75 else {
76 BondLengthMatrix = NULL;
77 delete(TempContainer);
78 }
79 return status;
80};
81
82/** Parses the bond lengths in a given file and puts them int a matrix form.
83 * \param *out output stream for debugging
84 * \param *mol molecule with atoms
85 * \return true - success, false - failed to construct bond structure
86 */
87bool BondGraph::ConstructBondGraph(molecule * const mol)
88{
89 Info FunctionInfo(__func__);
90bool status = true;
91
92 if (mol->start->next == mol->end) // only construct if molecule is not empty
93 return false;
94
95 if (BondLengthMatrix == NULL) { // no bond length matrix parsed?
96 SetMaxDistanceToMaxOfCovalentRadii(mol);
97 mol->CreateAdjacencyList(max_distance, IsAngstroem, &BondGraph::CovalentMinMaxDistance, this);
98 } else
99 mol->CreateAdjacencyList(max_distance, IsAngstroem, &BondGraph::BondLengthMatrixMinMaxDistance, this);
100
101 return status;
102};
103
104/** Returns the entry for a given index pair.
105 * \param firstelement index/atom number of first element (row index)
106 * \param secondelement index/atom number of second element (column index)
107 * \note matrix is of course symmetric.
108 */
109double BondGraph::GetBondLength(int firstZ, int secondZ)
110{
111 if (BondLengthMatrix == NULL)
112 return( -1. );
113 else
114 return (BondLengthMatrix->Matrix[0][firstZ][secondZ]);
115};
116
117/** Determines the maximum of all element::CovalentRadius for elements present in \a *mol.
118 * \param *out output stream for debugging
119 * \param *mol molecule with all atoms and their respective elements.
120 */
121double BondGraph::SetMaxDistanceToMaxOfCovalentRadii(const molecule * const mol)
122{
123 Info FunctionInfo(__func__);
124 max_distance = 0.;
125
126 atom *Runner = mol->start;
127 while (Runner->next != mol->end) {
128 Runner = Runner->next;
129 if (Runner->type->CovalentRadius > max_distance)
130 max_distance = Runner->type->CovalentRadius;
131 }
132 max_distance *= 2.;
133
134 return max_distance;
135};
136
137/** Returns bond criterion for given pair based on covalent radius.
138 * \param *Walker first BondedParticle
139 * \param *OtherWalker second BondedParticle
140 * \param &MinDistance lower bond bound on return
141 * \param &MaxDistance upper bond bound on return
142 * \param IsAngstroem whether units are in angstroem or bohr radii
143 */
144void BondGraph::CovalentMinMaxDistance(BondedParticle * const Walker, BondedParticle * const OtherWalker, double &MinDistance, double &MaxDistance, bool IsAngstroem)
145{
146 MinDistance = OtherWalker->type->CovalentRadius + Walker->type->CovalentRadius;
147 MinDistance *= (IsAngstroem) ? 1. : 1. / AtomicLengthToAngstroem;
148 MaxDistance = MinDistance + BONDTHRESHOLD;
149 MinDistance -= BONDTHRESHOLD;
150};
151
152/** Returns bond criterion for given pair based on a bond length matrix.
153 * The matrix should be contained in \a this BondGraph and contain an element-
154 * to-element length.
155 * \param *Walker first BondedParticle
156 * \param *OtherWalker second BondedParticle
157 * \param &MinDistance lower bond bound on return
158 * \param &MaxDistance upper bond bound on return
159 * \param IsAngstroem whether units are in angstroem or bohr radii
160 */
161void BondGraph::BondLengthMatrixMinMaxDistance(BondedParticle * const Walker, BondedParticle * const OtherWalker, double &MinDistance, double &MaxDistance, bool IsAngstroem)
162{
163 if (BondLengthMatrix == NULL) {// safety measure if no matrix has been parsed yet
164 DoeLog(2) && (eLog()<< Verbose(2) << "BondLengthMatrixMinMaxDistance() called without having parsed the bond length matrix yet!" << endl);
165 CovalentMinMaxDistance(Walker, OtherWalker, MinDistance, MaxDistance, IsAngstroem);
166 } else {
167 MinDistance = GetBondLength(Walker->type->Z-1, OtherWalker->type->Z-1);
168 MinDistance *= (IsAngstroem) ? 1. : 1. / AtomicLengthToAngstroem;
169 MaxDistance = MinDistance + BONDTHRESHOLD;
170 MinDistance -= BONDTHRESHOLD;
171 }
172};
173
174/** Counts the number of hydrogen bridge bonds.
175 * With \a *InterfaceElement an extra element can be specified that identifies some boundary.
176 * Then, counting is for the h-bridges that connect to interface only.
177 * \param *molecules molecules to count bonds
178 * \param *InterfaceElement or NULL
179 */
180int CountHydrogenBridgeBonds(MoleculeListClass *molecules, element * InterfaceElement = NULL)
181{
182 Info FunctionInfo(__func__);
183 atom *Walker = NULL;
184 atom *Runner = NULL;
185 Vector OHBond;
186 Vector OOBond;
187 int count = 0;
188 bool InterfaceFlag = false;
189 for (MoleculeList::const_iterator MolWalker = molecules->ListOfMolecules.begin();MolWalker != molecules->ListOfMolecules.end(); MolWalker++) {
190 Walker = (*MolWalker)->start;
191 while (Walker->next != (*MolWalker)->end) {
192 Walker = Walker->next;
193 for (MoleculeList::const_iterator MolRunner = molecules->ListOfMolecules.begin();MolRunner != molecules->ListOfMolecules.end(); MolRunner++) {
194 Runner = (*MolRunner)->start;
195 while (Runner->next != (*MolRunner)->end) {
196 Runner = Runner->next;
197 if ((Runner != Walker) && (Walker->type->Z == 8) && (Runner->type->Z == 8)) {
198 // check distance
199 const double distance = Runner->x.DistanceSquared(&Walker->x);
200 if ((distance > MYEPSILON) && (distance < HBRIDGEDISTANCE*HBRIDGEDISTANCE)) { // distance >0 means different atoms
201 InterfaceFlag = (InterfaceElement == NULL);
202 // on other atom(Runner) we check for bond to interface element
203 for (BondList::const_iterator BondRunner = Runner->ListOfBonds.begin(); ((!InterfaceFlag) && (BondRunner != Runner->ListOfBonds.end())); BondRunner++) {
204 atom * const OtherAtom = (*BondRunner)->GetOtherAtom(Runner);
205 InterfaceFlag = InterfaceFlag || (OtherAtom->type == InterfaceElement);
206 }
207 if (InterfaceFlag) {
208 // on this element (Walker) we check for bond to hydrogen, i.e. part of water molecule
209 for (BondList::const_iterator BondRunner = Walker->ListOfBonds.begin(); BondRunner != Walker->ListOfBonds.end(); BondRunner++) {
210 atom * const OtherAtom = (*BondRunner)->GetOtherAtom(Walker);
211 if (OtherAtom->type->Z == 1) {
212 // check angle
213 OHBond.CopyVector(&OtherAtom->x);
214 OHBond.SubtractVector(&Walker->x);
215 OOBond.CopyVector(&Runner->x);
216 OOBond.SubtractVector(&Walker->x);
217 const double angle = OHBond.Angle(&OOBond);
218 if (angle < M_PI*(30./180.)) {
219 DoLog(1) && (Log() << Verbose(1) << Walker->Name << ", " << OtherAtom->Name << " and " << Runner->Name << " have a hydrogen bridge bond with " << sqrt(distance) << " and at angle " << (180./M_PI)*angle << " degrees." << endl);
220 count++;
221 break;
222 }
223 }
224 }
225 }
226 }
227 }
228 }
229 }
230 }
231 }
232 return count;
233}
234
235/** Counts the number of bonds between two given elements.
236 * \param *molecules list of molecules with all atoms
237 * \param *first pointer to first element
238 * \param *second pointer to second element
239 * \return number of found bonds (\a *first-\a *second)
240 */
241int CountBondsOfTwo(MoleculeListClass * const molecules, const element * const first, const element * const second)
242{
243 atom *Walker = NULL;
244 int count = 0;
245
246 for (MoleculeList::const_iterator MolWalker = molecules->ListOfMolecules.begin();MolWalker != molecules->ListOfMolecules.end(); MolWalker++) {
247 Walker = (*MolWalker)->start;
248 while (Walker->next != (*MolWalker)->end) {
249 Walker = Walker->next;
250 if ((Walker->type == first) || (Walker->type == second)) { // first element matches
251 for (BondList::const_iterator BondRunner = Walker->ListOfBonds.begin(); BondRunner != Walker->ListOfBonds.end(); BondRunner++) {
252 atom * const OtherAtom = (*BondRunner)->GetOtherAtom(Walker);
253 if (((OtherAtom->type == first) || (OtherAtom->type == second)) && (Walker->nr < OtherAtom->nr)) {
254 count++;
255 DoLog(1) && (Log() << Verbose(1) << first->name << "-" << second->name << " bond found between " << *Walker << " and " << *OtherAtom << "." << endl);
256 }
257 }
258 }
259 }
260 }
261 return count;
262};
263
264/** Counts the number of bonds between three given elements.
265 * Note that we do not look for arbitrary sequence of given bonds, but \a *second will be the central atom and we check
266 * whether it has bonds to both \a *first and \a *third.
267 * \param *molecules list of molecules with all atoms
268 * \param *first pointer to first element
269 * \param *second pointer to second element
270 * \param *third pointer to third element
271 * \return number of found bonds (\a *first-\a *second-\a *third, \a *third-\a *second-\a *first, respectively)
272 */
273int CountBondsOfThree(MoleculeListClass * const molecules, const element * const first, const element * const second, const element * const third)
274{
275 int count = 0;
276 bool MatchFlag[2];
277 bool result = false;
278 atom *Walker = NULL;
279 const element * ElementArray[2];
280 ElementArray[0] = first;
281 ElementArray[1] = third;
282
283 for (MoleculeList::const_iterator MolWalker = molecules->ListOfMolecules.begin();MolWalker != molecules->ListOfMolecules.end(); MolWalker++) {
284 Walker = (*MolWalker)->start;
285 while (Walker->next != (*MolWalker)->end) {
286 Walker = Walker->next;
287 if (Walker->type == second) { // first element matches
288 for (int i=0;i<2;i++)
289 MatchFlag[i] = false;
290 for (BondList::const_iterator BondRunner = Walker->ListOfBonds.begin(); BondRunner != Walker->ListOfBonds.end(); BondRunner++) {
291 atom * const OtherAtom = (*BondRunner)->GetOtherAtom(Walker);
292 for (int i=0;i<2;i++)
293 if ((!MatchFlag[i]) && (OtherAtom->type == ElementArray[i])) {
294 MatchFlag[i] = true;
295 break; // each bonding atom can match at most one element we are looking for
296 }
297 }
298 result = true;
299 for (int i=0;i<2;i++) // gather results
300 result = result && MatchFlag[i];
301 if (result) { // check results
302 count++;
303 DoLog(1) && (Log() << Verbose(1) << first->name << "-" << second->name << "-" << third->name << " bond found at " << *Walker << "." << endl);
304 }
305 }
306 }
307 }
308 return count;
309};
Note: See TracBrowser for help on using the repository browser.