source: src/Fragmentation/Automation/unittests/WorkerPoolUnitTest.cpp@ 685e28

Action_Thermostats Add_AtomRandomPerturbation Add_FitFragmentPartialChargesAction Add_RotateAroundBondAction Add_SelectAtomByNameAction Added_ParseSaveFragmentResults AddingActions_SaveParseParticleParameters Adding_Graph_to_ChangeBondActions Adding_MD_integration_tests Adding_ParticleName_to_Atom Adding_StructOpt_integration_tests AtomFragments Automaking_mpqc_open AutomationFragmentation_failures Candidate_v1.5.4 Candidate_v1.6.0 Candidate_v1.6.1 ChangeBugEmailaddress ChangingTestPorts ChemicalSpaceEvaluator CombiningParticlePotentialParsing Combining_Subpackages Debian_Package_split Debian_package_split_molecuildergui_only Disabling_MemDebug Docu_Python_wait EmpiricalPotential_contain_HomologyGraph EmpiricalPotential_contain_HomologyGraph_documentation Enable_parallel_make_install Enhance_userguide Enhanced_StructuralOptimization Enhanced_StructuralOptimization_continued Example_ManyWaysToTranslateAtom Exclude_Hydrogens_annealWithBondGraph FitPartialCharges_GlobalError Fix_BoundInBox_CenterInBox_MoleculeActions Fix_ChargeSampling_PBC Fix_ChronosMutex Fix_FitPartialCharges Fix_FitPotential_needs_atomicnumbers Fix_ForceAnnealing Fix_IndependentFragmentGrids Fix_ParseParticles Fix_ParseParticles_split_forward_backward_Actions Fix_PopActions Fix_QtFragmentList_sorted_selection Fix_Restrictedkeyset_FragmentMolecule Fix_StatusMsg Fix_StepWorldTime_single_argument Fix_Verbose_Codepatterns Fix_fitting_potentials Fixes ForceAnnealing_goodresults ForceAnnealing_oldresults ForceAnnealing_tocheck ForceAnnealing_with_BondGraph ForceAnnealing_with_BondGraph_continued ForceAnnealing_with_BondGraph_continued_betteresults ForceAnnealing_with_BondGraph_contraction-expansion FragmentAction_writes_AtomFragments FragmentMolecule_checks_bonddegrees GeometryObjects Gui_Fixes Gui_displays_atomic_force_velocity ImplicitCharges IndependentFragmentGrids IndependentFragmentGrids_IndividualZeroInstances IndependentFragmentGrids_IntegrationTest IndependentFragmentGrids_Sole_NN_Calculation JobMarket_RobustOnKillsSegFaults JobMarket_StableWorkerPool JobMarket_unresolvable_hostname_fix MoreRobust_FragmentAutomation ODR_violation_mpqc_open PartialCharges_OrthogonalSummation PdbParser_setsAtomName PythonUI_with_named_parameters QtGui_reactivate_TimeChanged_changes Recreated_GuiChecks Rewrite_FitPartialCharges RotateToPrincipalAxisSystem_UndoRedo SaturateAtoms_findBestMatching SaturateAtoms_singleDegree StoppableMakroAction Subpackage_CodePatterns Subpackage_JobMarket Subpackage_LinearAlgebra Subpackage_levmar Subpackage_mpqc_open Subpackage_vmg Switchable_LogView ThirdParty_MPQC_rebuilt_buildsystem TrajectoryDependenant_MaxOrder TremoloParser_IncreasedPrecision TremoloParser_MultipleTimesteps TremoloParser_setsAtomName Ubuntu_1604_changes stable
Last change on this file since 685e28 was 3eb035, checked in by Frederik Heber <heber@…>, 13 years ago

FIX: Removed channel WorkerRemoved in WorkerPool as it may cause cyclic updates in FragmentScheduler.

  • If jobs are already present in the queue and an idle worker arrices, then marking a worker busy will cause an update inside the callback that is used to send the job to the new idle worker. This will trigger the same notification that is not yet removed to be called in notifyAll(). This causes a cycle in the updates.
  • Property mode set to 100644
File size: 5.4 KB
Line 
1/*
2 * Project: MoleCuilder
3 * Description: creates and alters molecular systems
4 * Copyright (C) 2010 University of Bonn. All rights reserved.
5 * Please see the LICENSE file or "Copyright notice" in builder.cpp for details.
6 */
7
8/*
9 * WorkerPoolUnitTest.cpp
10 *
11 * Created on: Feb 28, 2012
12 * Author: heber
13 */
14
15// include config.h
16#ifdef HAVE_CONFIG_H
17#include <config.h>
18#endif
19
20#include <cppunit/CompilerOutputter.h>
21#include <cppunit/extensions/TestFactoryRegistry.h>
22#include <cppunit/ui/text/TestRunner.h>
23
24#include "WorkerPoolUnitTest.hpp"
25
26#include <vector>
27
28#include "CodePatterns/Assert.hpp"
29#include "CodePatterns/Observer/Channels.hpp"
30#include "Pool/WorkerPool.hpp"
31#include "WorkerAddress.hpp"
32
33
34#ifdef HAVE_TESTRUNNER
35#include "UnitTestMain.hpp"
36#endif /*HAVE_TESTRUNNER*/
37
38/********************************************** Test classes **************************************/
39
40#include "stubs/FragmentJobStub.hpp"
41#include "unittests/stubs/ObserverStub.hpp"
42
43// Registers the fixture into the 'registry'
44CPPUNIT_TEST_SUITE_REGISTRATION( WorkerPoolTest );
45
46
47void WorkerPoolTest::setUp()
48{
49 // Throw assertions
50 ASSERT_DO(Assert::Throw);
51
52 pool = new WorkerPool();
53 addobserver = new NotificationObserver(pool->getChannel(WorkerPool::WorkerAdded));
54 idleobserver = new NotificationObserver(pool->getChannel(WorkerPool::WorkerIdle));
55
56 // and sign on
57 pool->signOn(addobserver, WorkerPool::WorkerAdded);
58 pool->signOn(idleobserver, WorkerPool::WorkerIdle);
59}
60
61void WorkerPoolTest::tearDown()
62{
63 pool->signOff(addobserver, WorkerPool::WorkerAdded);
64 pool->signOff(idleobserver, WorkerPool::WorkerIdle);
65
66 delete addobserver;
67 delete idleobserver;
68 delete pool;
69}
70
71/** UnitTest for working add/removeWorker
72 */
73void WorkerPoolTest::WorkerTest()
74{
75 WorkerAddress address("service", "port");
76 WorkerAddress otheraddress("otherservice", "otherport");
77
78 // add worker
79 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->idle_queue.size() );
80 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->busy_queue.size() );
81 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->pool.size() );
82 CPPUNIT_ASSERT ( pool->begin_idle() == pool->end_idle() );
83 CPPUNIT_ASSERT( pool->addWorker(address) );
84 CPPUNIT_ASSERT_EQUAL( (size_t)1, pool->idle_queue.size() );
85 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->busy_queue.size() );
86 CPPUNIT_ASSERT_EQUAL( (size_t)1, pool->pool.size() );
87 CPPUNIT_ASSERT ( pool->begin_idle() != pool->end_idle() );
88 CPPUNIT_ASSERT_EQUAL( address, pool->begin_idle()->second );
89 CPPUNIT_ASSERT( addobserver->wasNotified );
90 CPPUNIT_ASSERT( idleobserver->wasNotified );
91 addobserver->wasNotified = false;
92 idleobserver->wasNotified = false;
93
94 // remove non-present worker
95 std::cout << "The following error message is intended and does not indicate a failure." << std::endl;
96 CPPUNIT_ASSERT( !pool->removeWorker(otheraddress) );
97 CPPUNIT_ASSERT( !addobserver->wasNotified );
98 CPPUNIT_ASSERT( !idleobserver->wasNotified );
99
100 // check for presence
101 CPPUNIT_ASSERT( pool->presentInPool(address) );
102 CPPUNIT_ASSERT( !pool->presentInPool(otheraddress) );
103
104 // remove worker
105 CPPUNIT_ASSERT( pool->removeWorker(address) );
106 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->idle_queue.size() );
107 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->busy_queue.size() );
108 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->pool.size() );
109 CPPUNIT_ASSERT( !addobserver->wasNotified );
110 CPPUNIT_ASSERT( !idleobserver->wasNotified );
111}
112
113/** UnitTest for working (un)markWorkerBusy
114 */
115void WorkerPoolTest::markBusyTest()
116{
117 WorkerAddress address("service", "port");
118 CPPUNIT_ASSERT( pool->addWorker(address) );
119
120 // check that not busy
121 CPPUNIT_ASSERT( !pool->isWorkerBusy(address) );
122 CPPUNIT_ASSERT( !pool->hasBusyWorkers() );
123 CPPUNIT_ASSERT_EQUAL( (size_t)1, pool->idle_queue.size() );
124 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->busy_queue.size() );
125 CPPUNIT_ASSERT_EQUAL( (size_t)1, pool->pool.size() );
126 CPPUNIT_ASSERT( addobserver->wasNotified );
127 CPPUNIT_ASSERT( idleobserver->wasNotified );
128 addobserver->wasNotified = false;
129 idleobserver->wasNotified = false;
130
131 // unmark and check
132 pool->unmarkWorkerBusy(address);
133 CPPUNIT_ASSERT( !pool->isWorkerBusy(address) );
134 CPPUNIT_ASSERT( !pool->hasBusyWorkers() );
135 CPPUNIT_ASSERT_EQUAL( (size_t)1, pool->idle_queue.size() );
136 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->busy_queue.size() );
137
138 // mark as busy and check
139 const WorkerAddress otheraddress = pool->getNextIdleWorker();
140 CPPUNIT_ASSERT( pool->isWorkerBusy(address) );
141 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->idle_queue.size() );
142 CPPUNIT_ASSERT_EQUAL( (size_t)1, pool->busy_queue.size() );
143
144 // get one more
145 CPPUNIT_ASSERT( !pool->presentIdleWorkers() );
146#ifndef NDEBUG
147 std::cout << "The following assertion is intended and does not indicate a failure." << std::endl;
148 CPPUNIT_ASSERT_THROW( pool->getNextIdleWorker(), Assert::AssertionFailure );
149#else
150 const WorkerAddress emptyAddress = pool->getNextIdleWorker();
151#endif
152 CPPUNIT_ASSERT( pool->isWorkerBusy(address) );
153 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->idle_queue.size() );
154 CPPUNIT_ASSERT_EQUAL( (size_t)1, pool->busy_queue.size() );
155 CPPUNIT_ASSERT( !addobserver->wasNotified );
156 CPPUNIT_ASSERT( !idleobserver->wasNotified );
157
158 // unmark and check
159 pool->unmarkWorkerBusy(address);
160 CPPUNIT_ASSERT( !pool->isWorkerBusy(address) );
161 CPPUNIT_ASSERT_EQUAL( (size_t)1, pool->idle_queue.size() );
162 CPPUNIT_ASSERT_EQUAL( (size_t)0, pool->busy_queue.size() );
163 CPPUNIT_ASSERT( !addobserver->wasNotified );
164 CPPUNIT_ASSERT( idleobserver->wasNotified );
165}
Note: See TracBrowser for help on using the repository browser.